Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use before/after pagination on user blocks page #4637

Merged
merged 1 commit into from Apr 1, 2024

Conversation

AntonKhorev
Copy link
Contributor

image

This changes the order of blocks in the table, but:

  • The current order (by end date desc) is not very useful, because the beginning of the list is dominated by long-term blocks. You'll have to page through a lot of "Ends in almost 10 years" blocks for throwaway vandalism accounts before you reach "real" blocks for people to pay attention to, those are not 10 years right away.
  • There are plans to let the table be reordered, see Reorganize blocks table from status/revoked to begin/end/status columns #4200.

@tomhughes tomhughes changed the title Use before/after pagination on users page Use before/after pagination on user blocks page Apr 1, 2024
@tomhughes
Copy link
Member

So the new order is just by the block ID but sorting in descending order which effectively puts the most recent blocks first which is probably as useful as anything any certainly more useful than the current order as you say.

@tomhughes tomhughes merged commit c79da47 into openstreetmap:master Apr 1, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the blocks-pagination branch April 1, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants