Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt messages table to dark mode #4703

Merged
merged 4 commits into from Apr 23, 2024

Conversation

AntonKhorev
Copy link
Contributor

  • I remove the custom unread message background and replace it with table-success. The custom background was applied directly to table cells which we presumably don't want. This changes the green color used in the table.
  • I extend dark mode overrides to cover table-success.
  • I remove the inbox-row class. It was also used in the outbox.

Light mode before:
image

Light mode after:
image

Dark mode after:
image

@tordans
Copy link
Contributor

tordans commented Apr 15, 2024

Follow up: I think from an accessibility point of view we should consider encoding the information that we (only) present via background colors with text/html parts. Some ideas…

@tomhughes
Copy link
Member

I'm not sure about this one - the green is a bit pale for my tastes but I could probably live with that but what I really find a bit odd is the way the highlighted rows get a bolder lower border because table-success also changes the border colour.

@AntonKhorev
Copy link
Contributor Author

Lowered $table-border-factor:
image

@tomhughes
Copy link
Member

That looks much better, thanks.

@tomhughes tomhughes merged commit f99d737 into openstreetmap:master Apr 23, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the dark-mode-messages branch April 24, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants