Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom css applied to images inside paragraphs #4732

Merged
merged 1 commit into from Apr 28, 2024

Conversation

AntonKhorev
Copy link
Contributor

  • Many images are not inside <p>, this css doesn't apply to them.
  • width: auto is a default width
  • max-width: 100% shrinks images that are too wide to fit on the screen. Images inside rich text (diaries, comments) already have this set elsewhere.
  • It affects image on the copyright page, but that image is narrow enough. If there's any wide image that requires shrinking, .img-fluid can be used instead.
    image

@tomhughes
Copy link
Member

Looks good. I'll probably add img-fluid to that image anyway even thought he page has to be ludicrously narrow to trigger it there.

tomhughes added a commit to tomhughes/openstreetmap-website that referenced this pull request Apr 28, 2024
This preserves the old behaviour after openstreetmap#4732 is applied.
@tomhughes tomhughes merged commit fd732ee into openstreetmap:master Apr 28, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the no-p-img-css branch April 28, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants