Invert dark browse icons in dark mode #4735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some icons in the browse sidebar are too dark for dark mode. #4701 was a quick fix that could be applied to all icons. Here's another fix where only the selected dark icons are inverted.
In order to achieve that I did the following:
@each
loop that goes over the icon datacommon.scss
to avoid Sass processing errors because they now use Bootstrap mixins and Bootstrap is included incommon.scss
Node icons in dark mode:
Way icons are mostly unchanged.
Other required fixes: