Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert dark browse icons in dark mode #4735

Merged
merged 2 commits into from Apr 30, 2024

Conversation

AntonKhorev
Copy link
Contributor

@AntonKhorev AntonKhorev commented Apr 29, 2024

Some icons in the browse sidebar are too dark for dark mode. #4701 was a quick fix that could be applied to all icons. Here's another fix where only the selected dark icons are inverted.

In order to achieve that I did the following:

  • icon styles are set with a Sass @each loop that goes over the icon data
  • icon data is a nested Sass map where each icon has a filename and possibly an invert flag
  • css properties are moved to common.scss to avoid Sass processing errors because they now use Bootstrap mixins and Bootstrap is included in common.scss

Node icons in dark mode:
image image image image image image

Way icons are mostly unchanged.

Other required fixes:

@tomhughes
Copy link
Member

Very nice - all looks good to me, thanks.

@tomhughes tomhughes merged commit 2058251 into openstreetmap:master Apr 30, 2024
20 checks passed
@AntonKhorev AntonKhorev deleted the dark-mode-browse-icons branch May 1, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants