Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use font size instead of italic for changeset/trace descriptions #4813

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Contributor

The problem and links to previous solutions are in #2869. Changeset descriptions were made to use italics "to make them look more like quotes" but that doesn't work well with Chinese and maybe other writing systems and large blocks of italics don't look good. How else can the descriptions be rendered? I tried a few options:

  • Bold font: looks too bold. Intermediate font weights: not clear if they are going to be available with every font and writing system that might be in use.
  • Decorations like underline: can't use them because descriptions sometimes are links, sometimes are not links, sometimes they contain links inside.
  • Colors: also don't look right. Primary color is blue, that looks like a link. Secondary is gray we use for deemphasising. Other colors we mostly don't use, they stick out too much.

How about font size then? Let's make the font slightly bigger.

However that may make another problem worse. The text is now more likely not to fit horizontally. You can't always force words to wrap, but then horizontal scrolling should work fine just for the overflowing descriptions. Except it won't work fine when stretched links are used, and they are used in changeset lists. In this case let's truncate the text while still letting it to wrap if possible.

Screenshots in Chromium, because it shows scrollbars:
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant