Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an imagery blacklist to capabilities #806

Closed
wants to merge 1 commit into from

Conversation

pnorman
Copy link
Contributor

@pnorman pnorman commented Aug 30, 2014

This blacklist is for imagery which is of an incompatible license or ToS but is incorrectly used with some frequency.

This adds a element to the capabilities XML which contains the blacklist information within it.

@tomhughes, could you deploy this branch on errol for testing?

Also, when doing so could you add - ".*\\.stamen\\.com/.*" to application.yml? We need something blocked to test with, and stamen has layers that are unlikely to be in any presets or used.

Fixes trac 5024

This blacklist is for imagery which is of an incompatible license or ToS
but is incorrectly used with some frequency.

This adds a <policy> element to the capabilities XML which contains the
blacklist information within it
@tomhughes
Copy link
Member

Do the google ones not serve as tests? I don't think we should be blocking things just as a test...

Should there actually be any defaults committed though? or is that a deployment issue for our instance that should be done by chef?

@pnorman
Copy link
Contributor Author

pnorman commented Aug 30, 2014

Do the google ones not serve as tests? I don't think we should be blocking things just as a test...

I mean on errol for testing. Google isn't a good test, since JOSM is supposed to block it already, and they have painful URLs.

I kind of like the defaults, provided they're not OSM specific, which, for the case of Google, they're not. I'm not tied to the idea, but we'd probably want to then add them not just to api.osm.org, but to the test APIs

@tomhughes
Copy link
Member

Well I don't have any way to add something on errol that isn't on the live site... Or are you saying you want me to do a special test site or this? Seems a bit OTT for such a simple patch...

@tomhughes
Copy link
Member

Merged.

@tomhughes tomhughes closed this Aug 31, 2014
@pnorman pnorman deleted the blacklist branch September 20, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants