Update to Rails 4.2 #868
Merged
Update to Rails 4.2 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup our migrations, replacing as much of our custom code and monkey patching with modern standard rails methods.
Because rails now reads the defaults from the database correctly it no longer works to set them conditionally in after_initialise as they have already been set.
This doesn't seem to work with the new nokogiri based matching in rails 4.2 probably because the attribute is removed by the parser and used to set the namespace of the element.
|
typo: currently we have rails 4.1.9 |
|
No I meant that the 4.2 branch is currently based on 4.2.0, not that we are currently running that. |
|
Tried some stuff, couldn't produce any errors. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the site to use rails 4.2 (currently 4.2.0).
A test site is up at http://rails42.apis.dev.openstreetmap.org/ and things could probably do with a bit of testing before we merge this.