Adding user block start/end timestamps on block page #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-nelson
changed the title
|
Note: second screenshot was prior to me adding a space character between |
|
Thanks for the patch, but I wasn't particularly keen on showing both in one tooltip like that so I've take a slightly different approach in 4676179 and added a separate line for the creation time in the main view, with tooltips on both to get the details. That also makes the creation time more visible, which is probably a better fix for #923. |
|
Great, thanks! |
sbagroy986
pushed a commit
to sbagroy986/openstreetmap-website
that referenced
this pull request
Jul 24, 2015
Display the creation time, as a friendly date with a tooltip for the exact time, and add a tooltip to the expiry time. Fixes openstreetmap#923 and openstreetmap#996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Re: #923 and DWG experience. It would be great to have more detailed information about the extent of a block on the block page.
Approach
Similar to the styling of changesets' creation and closing timestamps, this PR adds an abbreviation tag to the status text of a user block detailing the creation and expiration of a user block. The information necessary is already available from
@user_block.Testing
On my local build, the page successfully rendered with the correct information. Attached are two examples:
A 4 day block:
A block that was revoked after ~4 minutes: