Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeLibraryPaths does not update the settings file OpenStudioApp.conf with new paths when it's not writable: warn user #372

Closed
jmarrec opened this issue Jun 1, 2021 · 1 comment · Fixed by #373
Closed

writeLibraryPaths does not update the settings file OpenStudioApp.conf with new paths when it's not writable: warn user #372

jmarrec opened this issue Jun 1, 2021 · 1 comment · Fixed by #373
Assignees
@jmarrec
Labels
component - Backend severity - Minor Bug 🐤

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 1, 2021

Issue overview

Current Behavior

writeLibraryPaths does not update the OpenStudioApp.conf with new paths

Expected Behavior

Upon loading a new library, I expect the ~/.config/NREL/OpenStudioApp.conf to be updated to include the library keys, but it does not

Steps to Reproduce

  1. Open OSapp
  2. File > Load Library > Select an OSM (eg DOE_Ref_pre_1980.osm)
  3. Look at ~/.config/NREL/OpenStudioApp.conf
  4. It does not include the "library" key

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Ubuntu 18.04
  • Version of OpenStudioApplication (if using an intermediate build, include SHA): v1.2.0-rc6

Context

Investigating #289
@jmarrec jmarrec added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jun 1, 2021
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 1, 2021

PEBKAB. Well kinda. this is mostly because I'm a developer, and because I have launched the App as sudo at one point, which had the effect of making my OpenStudioApp.conf owned by root. so settings.isWritable() is false

@jmarrec jmarrec changed the title writeLibraryPaths does not update the settings file OpenStudioApp.conf with new paths writeLibraryPaths does not update the settings file OpenStudioApp.conf with new paths when it's not writable: warn user Jun 1, 2021
@jmarrec jmarrec added component - Backend Enhancement Request New feature or request and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 1, 2021
@jmarrec jmarrec self-assigned this Jun 1, 2021
jmarrec added a commit that referenced this issue Jun 1, 2021
@jmarrec
Fix #372 - writeSettings / writeLibraryPaths warn user if settings ca…
e6b70fd 
…n't be written to
@jmarrec jmarrec added severity - Minor Bug 🐤 and removed Enhancement Request New feature or request labels Jun 1, 2021
@jmarrec jmarrec mentioned this issue Jun 1, 2021
Merged
macumber added a commit that referenced this issue Jun 7, 2021
@macumber
Merge pull request #373 from openstudiocoalition/372_Warn_Settings_no…
e4ab048 
…t_Writable

Fix #372 - writeSettings / writeLibraryPaths warn user if settings can't be written to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - Backend severity - Minor Bug 🐤
Projects
None yet
Milestone
No milestone
1 participant
@jmarrec