Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0-rc1 Testing: Call for help from the community #579

Closed
jmarrec opened this issue Dec 6, 2022 · 14 comments
Closed

v1.5.0-rc1 Testing: Call for help from the community #579

jmarrec opened this issue Dec 6, 2022 · 14 comments

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Dec 6, 2022

Testing Instructions

The first release candidate of the 1.5.0 release has been posted. The 1.5.0 is a major release. It udpates the OS SDK from 3.4.0 to 3.5.0.

Are you willing to test it out to help us make a great product? This will only take a few minutes of your time, yet it is absolutely critical for us to be aware of bugs.

Ready? You're awesome, thank you!

Go and download the executable from the v1.5.0-rc1 release. Please take a look at the release notes as they showcase the new features and bug fixes, so you know what to look for

Then try it out. You'll find a checklist below of things to try out, but please do feel free to go off-script, and if you can even try it out with your real world models that's even better.

When you're done, please report back by posting on this issue, with the following template filled out.

## Checklist

### Platform and version: <!--  eg: Ubuntu 20.04, macOS 10.15 x64, macOS 11.4 x64, macOS 12.3 arm64 (M1), Windows 10 20H2-->

* [ ] I could install the OpenStudioApp installer
* [ ] I could launch the OpenStudioApp.exe
* [ ] I can load File > Example > Example Model
* [ ] I can go to Geometry Preview and see the example model
* [ ] I can go to all tabs and see stuff loading
* [ ] I can create HVAC loops and assign a thermal zone
* [ ] I can search for Measures on the BCL (**Disclaimer**: we are aware this functionality is broken due to a regression in RemoteBCL, we are in the process of addressing it)
* [ ] I can put a measure in my workflow
* [ ] I can run a simulation
* [ ] I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
* [ ] I have tried enabling (and disabling) tab tracking with google analytics

## Problems found:

<!-- please describe -->

Thank you!

@jmarrec
Copy link
Collaborator Author

jmarrec commented Dec 6, 2022

Checklist

Platform and version: macOS 12.6 arm64 (M1) (Caveat: this is my developper machine)

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

  • After downloading a measure from BCL, I have to switch tabs to see it in the "Library" pane

    • Edit: actually looking at my ~/BCL folder, the download appears to have failed.
    • I have wipped by BCL folder, launching the App I get this: image
    • Trying to download a measure, the only thing I see in the console with OPENSTUDIO_APPLICATION_DEBUG=1 is multiple occurrences of: [openstudio.utilities.VersionString] <2> Could not parse '' as a version string.
    • I have a terrible network here, so don't know if it's a general issue or just mine.
  • The progress bar has been restyled: it is orange while it's doing things (which I'm fine with). But on the Run Tab, once it's done and the run completed successfully, it's red which I find confusing.

Screen Shot 2022-12-06 at 11 07 02

Screen Shot 2022-12-06 at 11 07 15

@macumber
Copy link
Collaborator

macumber commented Dec 6, 2022

Progress bar should only be red on error

@antoine-galataud
Copy link
Contributor

Checklist

Platform and version: Ubuntu 20.04

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Notes:

This version is sensibly slower than previous one. There is additional latency in launching the application, switching from tab to tab. The most notable performance issue is with the open file dialog that takes time to respond on every user interaction.

@j-lorrey
Copy link
Contributor

j-lorrey commented Dec 7, 2022

Checklist

Platform and version: Windows 10 Enterprise 21H2

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

  • When I downloaded a measure from the BCL, I didn't see it in my local measures library.
  • The HVAC Systems tab regularly took over 30 seconds to load. It never crashed though.
  • Progress bar was red on success, as reported earlier.

@eringold
Copy link
Contributor

eringold commented Dec 7, 2022

Checklist

Platform and version: Windows 11 22H2

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL (Disclaimer: we are aware this functionality is broken due to a regression in RemoteBCL, we are in the process of addressing it)
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

I cloned Air Loop HVAC 1 in the Example File (by clicking the blue 'x2' button), and all SetpointManager:MixedAirs on the resulting loop had their 'node name' fields updated correctly, except the SPM on the AirLoopHVAC:OutdoorAirSystem. OSApp 1.3 shows same behavior, so this is not new.

FWIW, I'm not experiencing much performance difference from 1.3.0. The app seems to be responding just as well as before.

@craigers290
Copy link
Collaborator

Checklist

Windows 10 21H2

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL (Disclaimer: we are aware this functionality is broken due to a regression in RemoteBCL, we are in the process of addressing it)
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

Geometry tab took several minutes to load with fairly simple geometry generated with floorspace.js. Aside from geometry other inputs had all been set by CreateTypical through PAT. The first time I closed the App figuring it had crashed. Then I inadvertently left it open and it did eventually load but was also slow to respond to manipulations. The geometry does seem to have some Floorspace.js weirdness but loads fine in other versions.

in.osm.txt

@macumber
Copy link
Collaborator

macumber commented Dec 11, 2022

Checklist

Platform and version: Windows 11 Pro 21H2

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can create small model using FloorspaceJS
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL (Disclaimer: we are aware this functionality is broken due to a regression in RemoteBCL, we are in the process of addressing it)
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

Space Types library item collapses after dragging in Space Type from library

@apope9
Copy link

apope9 commented Dec 12, 2022

Checklist

Platform and version: Windows 10 Pro

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results) (**red status bar even when sim is successful)
  • I have tried enabling (and disabling) tab tracking with google analytics

@jmarrec
Copy link
Collaborator Author

jmarrec commented Dec 20, 2022

Problems found:

Geometry tab took several minutes to load with fairly simple geometry generated with floorspace.js. Aside from geometry other inputs had all been set by CreateTypical through PAT. The first time I closed the App figuring it had crashed. Then I inadvertently left it open and it did eventually load but was also slow to respond to manipulations. The geometry does seem to have some Floorspace.js weirdness but loads fine in other versions.

in.osm.txt

@craigers290 this is happening in the OS SDK, not the OS App.

time openstudio -e "vt = OpenStudio::OSVersion::VersionTranslator.new; model = vt.loadModel('craig.osm').get; ft = OpenStudio::Model::ThreeJSForwardTranslator.new; scene = ft.modelToThreeJS(model, true)"

real	1m52,057s
user	1m51,140s
sys	0m0,803s

if I pass triangulated = false, it takes less than a second:

time openstudio -e "vt = OpenStudio::OSVersion::VersionTranslator.new; model = vt.loadModel('craig.osm').get; ft = OpenStudio::Model::ThreeJSForwardTranslator.new; scene = ft.modelToThreeJS(model, false)"

real	0m0,994s
user	0m0,973s
sys	0m0,020s

Would you happen to have an earlier version of this same model (which is at 3.5.0). I'm hoping to test backwards, to see if I can pinpoint a change.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Dec 20, 2022

Actually I managed to just remove the thermalZones (and equipments), SizingPeriod:DesignDay, and WeatherFile and change the version to 3.2.0 without problems. Here are the results:

Version Real (s)
3.2.0 309
3.3.0 309
3.4.0 122
3.5.0 112

Seems like you have several surfaces with a way too high number of vertices to begin with, could be related.

 m.getSurfaces.map(&:vertices).map(&:size).sort.reverse.first(5)
=> [14, 14, 10, 10, 6]

But apparently it's not: m.getSurfaces.filter{|s| s.vertices.size >= 10}.each(&:remove) then scene = ft.modelToThreeJS(m, true) still takes for ever.

You also have a few surfaces with a very high number of sub surfaces on it.

m.getSurfaces.map(&:subSurfaces).map(&:size).sort.reverse.first(10)
=> [24, 18, 15, 8, 4, 2, 2, 0, 0, 0]

If I remove the one with 24 surfaces (and it's subSurfaces), then the result is immediate.

[35] Temp(main)>m = osload('craig2.osm')
=> #<OpenStudio::Model::Model:0x000055c154b60e70 @__swigtype__="_p_openstudio__model__Model">

[36] Temp(main)> m.getSurfaces.size + m.getSubSurfaces.size
=> 143
[37] Temp(main)> m.getSurfaces.filter{|s| s.subSurfaces.size >= 24}.each(&:remove)
=> [#<OpenStudio::Model::Surface:0x000055c1548c01e8 @__swigtype__="_p_openstudio__model__Surface">]
[38] Temp(main)> m.getSurfaces.size + m.getSubSurfaces.size
=> 118
[40] Temp(main)> s = Time.now; scene = ft.modelToThreeJS(m, true); puts "#{(Time.now - s).round(2)} seconds"
3.73 seconds

@AmmarDeh
Copy link

AmmarDeh commented Dec 30, 2022

Checklist

Platform and version: Windows 10 Enterprise 20H2

  • I could install the OpenStudioApp installer
  • I could launch the OpenStudioApp.exe
  • I can load File > Example > Example Model
  • I can go to Geometry Preview and see the example model
  • I can go to all tabs and see stuff loading
  • I can create HVAC loops and assign a thermal zone
  • I can search for Measures on the BCL (Disclaimer: we are aware this functionality is broken due to a regression in RemoteBCL, we are in the process of addressing it)
  • I can put a measure in my workflow
  • I can run a simulation
  • I can see the simulation results (EnergyPlus Outputs, OpenStudio Results)
  • I have tried enabling (and disabling) tab tracking with google analytics

Problems found:

  1. In the Geometry tab, clicking on "orthographic" or "Reset" will do nothing unless I click somewhere on the canvas or enabling/disabling filters.
  2. I can search the BCL, but the downloaded measures do not appear on the library or the local measures directory.
  3. The run simulation bar appears in red even though the simulation completed successfully.

@antoine-galataud
Copy link
Contributor

@AmmarDeh

In the Geometry tab, clicking on "orthographic" or "Reset" will do nothing unless I click somewhere on the canvas or enabling/disabling filters

I can reproduce this. I've opened #585 and I'll propose a fix soon.

@antoine-galataud
Copy link
Contributor

Here it is: #586

@jmarrec
Copy link
Collaborator Author

jmarrec commented Jan 9, 2023

Thanks everyone! 1.5.0 is officially out.

@jmarrec jmarrec closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants