-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5.0-rc1 Testing: Call for help from the community #579
Comments
ChecklistPlatform and version: macOS 12.6 arm64 (M1) (Caveat: this is my developper machine)
Problems found:
|
Progress bar should only be red on error |
ChecklistPlatform and version: Ubuntu 20.04
Notes: This version is sensibly slower than previous one. There is additional latency in launching the application, switching from tab to tab. The most notable performance issue is with the open file dialog that takes time to respond on every user interaction. |
ChecklistPlatform and version: Windows 10 Enterprise 21H2
Problems found:
|
ChecklistPlatform and version: Windows 11 22H2
Problems found:I cloned Air Loop HVAC 1 in the Example File (by clicking the blue 'x2' button), and all FWIW, I'm not experiencing much performance difference from 1.3.0. The app seems to be responding just as well as before. |
ChecklistWindows 10 21H2
Problems found:Geometry tab took several minutes to load with fairly simple geometry generated with floorspace.js. Aside from geometry other inputs had all been set by CreateTypical through PAT. The first time I closed the App figuring it had crashed. Then I inadvertently left it open and it did eventually load but was also slow to respond to manipulations. The geometry does seem to have some Floorspace.js weirdness but loads fine in other versions. |
ChecklistPlatform and version: Windows 11 Pro 21H2
Problems found:Space Types library item collapses after dragging in Space Type from library |
ChecklistPlatform and version: Windows 10 Pro
|
@craigers290 this is happening in the OS SDK, not the OS App. time openstudio -e "vt = OpenStudio::OSVersion::VersionTranslator.new; model = vt.loadModel('craig.osm').get; ft = OpenStudio::Model::ThreeJSForwardTranslator.new; scene = ft.modelToThreeJS(model, true)"
real 1m52,057s
user 1m51,140s
sys 0m0,803s if I pass triangulated = false, it takes less than a second: time openstudio -e "vt = OpenStudio::OSVersion::VersionTranslator.new; model = vt.loadModel('craig.osm').get; ft = OpenStudio::Model::ThreeJSForwardTranslator.new; scene = ft.modelToThreeJS(model, false)"
real 0m0,994s
user 0m0,973s
sys 0m0,020s Would you happen to have an earlier version of this same model (which is at 3.5.0). I'm hoping to test backwards, to see if I can pinpoint a change. |
Actually I managed to just remove the thermalZones (and equipments), SizingPeriod:DesignDay, and WeatherFile and change the version to 3.2.0 without problems. Here are the results:
Seems like you have several surfaces with a way too high number of vertices to begin with, could be related. m.getSurfaces.map(&:vertices).map(&:size).sort.reverse.first(5)
=> [14, 14, 10, 10, 6] But apparently it's not: You also have a few surfaces with a very high number of sub surfaces on it. m.getSurfaces.map(&:subSurfaces).map(&:size).sort.reverse.first(10)
=> [24, 18, 15, 8, 4, 2, 2, 0, 0, 0] If I remove the one with 24 surfaces (and it's subSurfaces), then the result is immediate. [35] Temp(main)>m = osload('craig2.osm')
=> #<OpenStudio::Model::Model:0x000055c154b60e70 @__swigtype__="_p_openstudio__model__Model">
[36] Temp(main)> m.getSurfaces.size + m.getSubSurfaces.size
=> 143
[37] Temp(main)> m.getSurfaces.filter{|s| s.subSurfaces.size >= 24}.each(&:remove)
=> [#<OpenStudio::Model::Surface:0x000055c1548c01e8 @__swigtype__="_p_openstudio__model__Surface">]
[38] Temp(main)> m.getSurfaces.size + m.getSubSurfaces.size
=> 118
[40] Temp(main)> s = Time.now; scene = ft.modelToThreeJS(m, true); puts "#{(Time.now - s).round(2)} seconds"
3.73 seconds |
ChecklistPlatform and version: Windows 10 Enterprise 20H2
Problems found:
|
Here it is: #586 |
Thanks everyone! 1.5.0 is officially out. |
Testing Instructions
The first release candidate of the 1.5.0 release has been posted. The 1.5.0 is a major release. It udpates the OS SDK from 3.4.0 to 3.5.0.
Are you willing to test it out to help us make a great product? This will only take a few minutes of your time, yet it is absolutely critical for us to be aware of bugs.
Ready? You're awesome, thank you!
Go and download the executable from the v1.5.0-rc1 release. Please take a look at the release notes as they showcase the new features and bug fixes, so you know what to look for
Then try it out. You'll find a checklist below of things to try out, but please do feel free to go off-script, and if you can even try it out with your real world models that's even better.
When you're done, please report back by posting on this issue, with the following template filled out.
Thank you!
The text was updated successfully, but these errors were encountered: