Fix #304 - Add new HumidifierSteamGas to the OpenStudioApplication #307
Conversation
jmarrec
added
Enhancement Request
| return model | ||
| end | ||
|
|
||
| m = osload('hvac_library.osm') |
There was a problem hiding this comment.
Is this script supposed to be run multiple times or just once? Should it remove existing humidifiers? Seems like a useful new pattern but not quit sure what the pattern is.
There was a problem hiding this comment.
@macumber Thanks you for your contribution to OpenStudioApplication. This question is answered in our wiki at https://github.com/openstudiocoalition/OpenStudioApplication/wiki/Registering-a-new-SDK-object-in-the-OSApp#hvac-components-adding-them-to-the-hvac_library
Joke aside, this is supposed to be run (probably by me) once we have the official installer (or at least an IOFreeze version) and we bump the hvac_library to a new version. Otherwise I would be VT'ing the hvac_library now, while other VT rules haven't been added yet in the SDK, and risk putting the hvac_library in a broken state. I applied the same pattern for the last release.
| @@ -191,6 +191,7 @@ IconLibrary::IconLibrary() { | |||
| new QPixmap(":images/heatpump_watertowater_equationfit_heating.png"); | |||
| m_icons[openstudio::IddObjectType(openstudio::IddObjectType::OS_Humidifier_Steam_Electric).value()] = | |||
| new QPixmap(":images/electric_humidifier.png"); | |||
| m_icons[openstudio::IddObjectType(openstudio::IddObjectType::OS_Humidifier_Steam_Gas).value()] = new QPixmap(":images/gas_humidifier.png"); | |||
There was a problem hiding this comment.
New icon looks cool, did you make it?
There was a problem hiding this comment.
I did. If you look closely, you can see pixelisation from my approximate use of Gimp. I never "create" icons as I lack the necessary skills. I usually take an icon, and add a portion of another icon or two or something.
electric_humidifier.png
+ series_fan_terminal.png
= gas_humidifier.png
|
Not sure what is going on with CI, would the new CPack stuff you did fix that? |
|
I had the same CI problem on the pre-release build I had triggered the other day. I think it was a temporary github issue. i'm rebooting this one and we'll see. |
|
I don't know what CI is doing, but it's not related to this PR. I'm merging it in. |
``` cd src/openstudio_app/Resources/default /usr/local/openstudio-3.2.0/bin/openstudio add_humidifier_steam_gas.rb ```
Fix #304 - Add new HumidifierSteamGas to the OpenStudioApplication