Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.2.0 rc2 #352

Merged
merged 32 commits into from May 28, 2021
Merged

V1.2.0 rc2 #352

merged 32 commits into from May 28, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 28, 2021

merge

macumber and others added 30 commits May 15, 2021 18:56
…show non-strict matches for ZoneAirContaminantBalance Outdoor Carbon Dioxide schedule

Fixes #268
https://raw.githubusercontent.com/mrdoob/three.js/r98/build/three.min.js


geez... sooooo, I realized that loading the r71 from a CDN worked... Then I tried to upgrade threeJS from r71 (current) to r128 (latest). Can't do, too many things are gone.

I managed to make r98 work... It's the last release with ObjectLoader working. see https://github.com/mrdoob/three.js/wiki/Migration-Guide#r98--r99:

> JSONLoader has been removed from core. It is now located in examples/js/loaders/deprecated/LegacyJSONLoader.js.
> Removed Geometry support from ObjectLoader. You have to include LegacyJSONLoader if you still want to load geometry data of type Geometry.

then I manually did the equivalent of a git bisect

r79 fails, r80 works

diffing the three.js (not minified) is kinda pointless, nothing matches. The migration guide is empty for r77 to r80.. https://github.com/mrdoob/three.js/wiki/Migration-Guide#r76--r77

So anyways, bumping to r98 fixes the Ubuntu 20.04 problem.
…taller

Fix  #345 - Missing libs in Ubuntu installer
…view

Fix #95 - Make Geometry Preview work on Ubuntu 20.04 (workaround)
@jmarrec jmarrec merged commit f10b850 into develop May 28, 2021
@jmarrec jmarrec deleted the v1.2.0-rc2 branch May 28, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants