Implement support for further grouping HVAC library by category #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
1. implement OSCategoryPlaceholder class for further grouping inside OSCollapsibleItemList 2. Modification to search bar to use category in addition to type and name.
jmarrec
reviewed
May 13, 2024
| Q_OBJECT | ||
|
|
||
| public: | ||
| OSCategoryPlaceholder(const std::string& text, QWidget* parent = nullptr); |
There was a problem hiding this comment.
Suggested change
| OSCategoryPlaceholder(const std::string& text, QWidget* parent = nullptr); | |
| explicit OSCategoryPlaceholder(const std::string& text, QWidget* parent = nullptr); |
Comment on lines
58
to
59
| m_itemsType(OSItemType::ListItem), | ||
| m_placeholderItems() { |
There was a problem hiding this comment.
Suggested change
| m_itemsType(OSItemType::ListItem), | |
| m_placeholderItems() { | |
| m_itemsType(OSItemType::ListItem) { |
jmarrec
reviewed
May 13, 2024
There was a problem hiding this comment.
Alright, this is neat, thanks a lot @manuvarkey
I do question whether we shouldn't use an actual OSCollapsibleItemHeader directly, so we can expand it or not.
Here is a demo of the current code:
Comment on lines
+171
to
+175
| void OSCollapsibleItemList::addCategoryPlaceholderItem(OSCategoryPlaceholder* categoryPlaceholderItem) { | ||
|
|
||
| m_placeholderItems.push_back(categoryPlaceholderItem); | ||
| m_vLayout->insertWidget(0, categoryPlaceholderItem); | ||
| } |
There was a problem hiding this comment.
@macumber This makes me realize we have a std::vector<OSCollapsibleItem*> m_collapsibleItems; but our void OSCollapsibleItemList::addCollapsibleItem(OSCollapsibleItem* collapsibleItem) does not add to it... even though other functions loop on it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSCategoryPlaceholderclass for further grouping insideOSCollapsibleItemList