-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nextcloud Music as a participating server #84
Add Nextcloud Music as a participating server #84
Conversation
The Nextcloud Music app has a rudimentary support for the OpenAmpache API extensions starting from the version 1.10.0.
✅ Deploy Preview for opensubsonic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OpenAmpache: it's OpenSubsonic :) But nice! Do you plan to add support for extensions and additional fields? If yes do you want to be added to the OS org in the server group? |
Oops, sorry, that's what I meant to say :D
I probably will support at least some of them, eventually. Especially if there are any low-hanging-fruits.
I'm not quite sure what are the implications of this. But if this doesn't come with any commitments, then it probably wouldn't hurt. |
It does not really have any, it gives you a vote on new APIs. The only commitment here is not really tied to being in the org, it's just that if you propose an API, field, whatever and it's implemented you engage yourself in supporting it in your server or client as a sign of respect. But since you are the initiator it's mostly just common sense. |
@Tolriq Okay, by all means, sign me in. |
@paulijar Seems there's some issues in the search3 end point returning duplicates : https://support.symfonium.app/t/no-tracks-listed-in-any-of-the-synced-albums/3512 You probably miss a sort in the query in that case most SQL servers with pagination results are undefined. |
@Tolriq Thanks for the report. However, I couldn't immediately reproduce the problem. The DB queries here also sort the results by the title/name fields so that shouldn't be the issue here. What kind of API requests do you send when you see this? |
@paulijar The user is supposed to report to your repo I'll join there when he does it's not the good place :)
But I think the root issue might be
And then both search3 with the 2 folderIds returns the same data. Is this something normal? |
Yes, that's normal. Is it a problem for your client? The thing is, Nextcloud Music abuses the folder system of the Subsonic API a bit. To understand why, it should be noted that the first reference clients I used 5 years ago were targeting quite old API versions and they didn't have any support for the metadata browsing using the methods like There are never any other musicFolders except these two fake folders as we support only single top-level folder for the music library. This may be subject to change in the future, though. If that happens, then I need to rethink the use of musicFolders in the Subsonic API and I might decide to drop this legacy hack or at least make it configurable. |
The app sync all for offline first usage via search3. Since it sees 2 library it sync both so triggers duplicate that I can filter, but still duplicate all the requests and data so highly inefficient. I can add a special handling to ignore the second one for your server type. Do you return different values for next cloud/owncloud ? Are the IDs always the same? So that if the future you support real multiple folders you can avoid reusing the -2 to avoid me skipping a valid folder ? |
The Subsonic API works exactly the same on Nextcloud and ownCloud. The IDs are always the same for these two fake folders: -1 and -2. If the real multi-folder support will come, then those folders will have positive ID values. |
The Nextcloud Music app has a rudimentary support for the
OpenAmpacheOpenSubsonic API extensions starting from the version 1.10.0 (released today 2024-01-27).The same application may be called also ownCloud Music, depending on the host cloud used.