fix: some event should not be dispose while switch session #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.63% // Head: 57.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
- Coverage 57.63% 57.63% -0.01%
==========================================
Files 1284 1284
Lines 80389 80390 +1
Branches 16823 16823
==========================================
- Hits 46332 46331 -1
- Misses 30976 30978 +2
Partials 3081 3081
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ricbet
approved these changes
Oct 28, 2022
erha19
added a commit
that referenced
this pull request
Oct 28, 2022
erha19
added a commit
that referenced
this pull request
Oct 31, 2022
* test: add opened editor e2e test * chore: update split editor timeout * chore: trigger editor title menu by id * feat: 优化部分启动逻辑 (#1772) * feat: optimize initialize performance * chore: deps * refactor: (wip) add lifecycle service * refactor: (wip) * refactor: 重构 vscode contributes 运行机制 * fix: test case * chore: unused code * refactor: register language logic * chore: test case * chore: test case * chore: revert config * fix: theme contribution * chore: update comments * chore: fix build error Co-authored-by: Dan <danwu.wdw@alibaba-inc.com> * chore: update labeler.yml * fix: some event should not be dispose while switch session (#1866) * refactor: parallel open resource (#1873) * chore: improve append view performance (#1871) * chore: improve append view performance * chore: improve append view performance * fix: submenus error (#1867) * chore: update view quick open prefix (#1869) * test: implement run debug e2e test case (#1787) * test: implement debug breakpoint editor glyph margin test case * test: code * test: implement run debug test case * fix: ci * fix: ci * fix: ci * chore: fix ci * test: implement debug breakpoint editor glyph margin test case * fix: improve debug code Co-authored-by: kuiwu <danwu.wdw@alibaba-inc.com> * chore: change filetree context menu order (#1868) * chore: fix new file test Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com> Co-authored-by: John <qingyi.xjh@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
revert some code change by #1859.
Changelog