Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change filetree context menu order #1868

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 28, 2022

Types

  • 🧹 Chores

Background or solution

调整文件树右键菜单的默认排序顺序,使其更符合用户习惯

Changelog

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 15.89% // Head: 57.63% // Increases project coverage by +41.74% 🎉

Coverage data is based on head (ce6cd3f) compared to base (76efb84).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1868       +/-   ##
===========================================
+ Coverage   15.89%   57.63%   +41.74%     
===========================================
  Files        1284     1284               
  Lines       80390    80390               
  Branches    16823    16823               
===========================================
+ Hits        12775    46332    +33557     
+ Misses      61806    30977    -30829     
+ Partials     5809     3081     -2728     
Flag Coverage Δ
jsdom 52.39% <ø> (?)
node 15.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/path.ts 77.89% <0.00%> (+0.98%) ⬆️
packages/utils/src/errors.ts 46.05% <0.00%> (+1.31%) ⬆️
packages/utils/src/map.ts 84.33% <0.00%> (+1.35%) ⬆️
packages/core-browser/src/menu/next/menu-id.ts 100.00% <0.00%> (+1.38%) ⬆️
packages/editor/src/common/editor.ts 100.00% <0.00%> (+2.08%) ⬆️
packages/task/src/browser/problem-line-matcher.ts 2.21% <0.00%> (+2.21%) ⬆️
...ension/src/common/vscode/testing/testCollection.ts 2.55% <0.00%> (+2.55%) ⬆️
...rminal-next/src/browser/terminal.ext.host.proxy.ts 2.63% <0.00%> (+2.63%) ⬆️
packages/core-common/src/reference.ts 98.64% <0.00%> (+2.70%) ⬆️
packages/editor/src/browser/index.ts 73.61% <0.00%> (+2.77%) ⬆️
... and 785 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet merged commit 910be5a into main Oct 28, 2022
@Ricbet Ricbet deleted the chore/file-tree/menu-order branch October 28, 2022 08:27
erha19 added a commit that referenced this pull request Oct 31, 2022
* test: add opened editor e2e test

* chore: update split editor timeout

* chore: trigger editor title menu by id

* feat: 优化部分启动逻辑 (#1772)

* feat: optimize initialize performance

* chore: deps

* refactor: (wip) add lifecycle service

* refactor: (wip)

* refactor: 重构 vscode contributes 运行机制

* fix: test case

* chore: unused code

* refactor: register language logic

* chore: test case

* chore: test case

* chore: revert config

* fix: theme contribution

* chore: update comments

* chore: fix build error

Co-authored-by: Dan <danwu.wdw@alibaba-inc.com>

* chore: update labeler.yml

* fix: some event should not be dispose while switch session (#1866)

* refactor: parallel open resource (#1873)

* chore: improve append view performance (#1871)

* chore: improve append view performance

* chore: improve append view performance

* fix: submenus error (#1867)

* chore: update view quick open prefix (#1869)

* test: implement run debug e2e test case (#1787)

* test: implement debug breakpoint editor glyph margin test case

* test: code

* test: implement run debug test case

* fix: ci

* fix: ci

* fix: ci

* chore: fix ci

* test: implement debug breakpoint editor glyph margin test case

* fix: improve debug code

Co-authored-by: kuiwu <danwu.wdw@alibaba-inc.com>

* chore: change filetree context menu order (#1868)

* chore: fix new file test

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
Co-authored-by: John <qingyi.xjh@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants