Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ExtensionDidContributes event for themes #214

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 27, 2021

Types

  • 🐛 Bug Fixes

Background or solution

  1. 添加 ExtensionDidContributes 事件
  2. 注册主题时若是已设置的自动应用
  3. 主题全部注册完成后,如果已设置的主题没有安装,fallback 到默认主题

默认主题相关修改

  1. 合并所有定义到 plus.json, 原因是之前定义了三层的继承关系(include), 但实际是不必要的,需要分别读取三个文件,导致加载主题时较慢

Changelog

  • 修正主题 fallback 逻辑

@codecov-commenter
Copy link

Codecov Report

Merging #214 (0a7af35) into main (f3ec863) will decrease coverage by 0.00%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   59.40%   59.39%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       72358    72366       +8     
  Branches    14980    14982       +2     
==========================================
- Hits        42984    42983       -1     
- Misses      26771    26778       +7     
- Partials     2603     2605       +2     
Impacted Files Coverage Δ
...kages/theme/src/browser/workbench.theme.service.ts 71.21% <64.28%> (-0.99%) ⬇️
packages/core-common/src/types/extension.ts 90.00% <100.00%> (+1.11%) ⬆️
...ackages/extension/src/browser/extension.service.ts 48.04% <100.00%> (+0.20%) ⬆️
...ore-browser/src/preferences/preference-provider.ts 66.89% <0.00%> (-6.90%) ⬇️
.../core-browser/src/preferences/early-preferences.ts 90.56% <0.00%> (-1.89%) ⬇️
packages/main-layout/src/browser/layout.service.ts 67.43% <0.00%> (+2.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ec863...0a7af35. Read the comment docs.

@erha19 erha19 merged commit b8a01dc into main Dec 27, 2021
@erha19 erha19 deleted the fix/default-theme-logic branch December 27, 2021 07:01
erha19 pushed a commit that referenced this pull request Dec 27, 2021
* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)
erha19 added a commit that referenced this pull request Dec 28, 2021
* feat: support component cdn type configuration (#154)

* feat: support component cdn type configuration

* chore: add release branch to workflow

* chore: fix lint error

* chore: 2.13.2

* fix: set correct component cdn url (#158)

* chore: 2.13.3

* fix: editor save issue (#189)

* chore: 2.13.4

* fix: use temp uri to build storage path while workspace is undefined (#210)

* chore: 2.13.5

* fix: theme fallback logic (#220)

* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)

* chore: 2.13.6

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
erha19 added a commit that referenced this pull request Dec 29, 2021
* feat: support component cdn type configuration (#154)

* feat: support component cdn type configuration

* chore: add release branch to workflow

* chore: fix lint error

* chore: 2.13.2

* fix: set correct component cdn url (#158)

* chore: 2.13.3

* fix: editor save issue (#189)

* chore: 2.13.4

* fix: use temp uri to build storage path while workspace is undefined (#210)

* chore: 2.13.5

* fix: theme fallback logic (#220)

* fix: add ExtensionDidContributes event for themes (#214)

* fix: remove theme fallback logic (#188)

* chore: 2.13.6

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants