Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): add protocol for ext document service #3614

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented May 6, 2024

Types

  • 🎉 New Features

Background or solution

当我们打开一个文件的时候,会向插件进程发送一个 fireModelOpenedEvent 事件,这个事件包含了 model 的全文,如果我们使用 json 序列化的话,数据会膨胀的非常大。

过去:

9.5m -> 12.5m
CleanShot 2024-05-06 at 15 30 19@2x

10.5m -> 62.9m
CleanShot 2024-05-06 at 15 30 43@2x

现在:

9.5m -> 9.6m

CleanShot 2024-05-06 at 15 36 02@2x

10.5m -> 10.5m

CleanShot 2024-05-06 at 15 36 20@2x

Changelog

Copy link

railway-app bot commented May 6, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🎨 feature feature required label May 6, 2024
@bytemain
Copy link
Member Author

bytemain commented May 6, 2024

这个 62.9m 的例子可以用这个文件来复现:

dd if=/dev/zero of=10m.txt bs=10m count=1

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.07%. Comparing base (b5df89c) to head (5ae9ee4).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/connection/src/common/rpc/multiplexer.ts 92.30% 1 Missing ⚠️
packages/extension/src/hosted/ext.process-base.ts 0.00% 1 Missing ⚠️
packages/extension/src/hosted/worker.host.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
+ Coverage   56.05%   56.07%   +0.01%     
==========================================
  Files        1510     1512       +2     
  Lines       91707    91794      +87     
  Branches    18795    18813      +18     
==========================================
+ Hits        51407    51471      +64     
- Misses      33433    33451      +18     
- Partials     6867     6872       +5     
Flag Coverage Δ
jsdom 51.49% <90.00%> (+0.01%) ⬆️
node 15.65% <46.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 50291b6 into main May 6, 2024
13 checks passed
@bytemain bytemain deleted the feat/add-protocol-1 branch May 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants