Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update ext protocol registration #3616

Merged
merged 1 commit into from
May 6, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented May 6, 2024

Types

  • 🪚 Refactors

Background or solution

我们有两个 ext host: worker 和 node,每次给这俩发消息,同一个内容要序列化两遍,实际上只需要序列化一次发一遍就好。

比如说: #3614 这里面提到的,fireModelOpenedEvent,打开一个 10M 文件,会对这个 10M 文件序列化两遍

要改动的话会非常大,这里先做一下 refactor

Changelog

Copy link

railway-app bot commented May 6, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the ⚙️ refactor Refactor code label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 72.39264% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 56.09%. Comparing base (197b8ef) to head (b10bc13).
Report is 1 commits behind head on main.

Files Patch % Lines
.../browser/vscode/api/main.thread.api.shared-impl.ts 76.52% 27 Missing ⚠️
...ackages/extension/src/browser/extension.service.ts 62.50% 5 Missing and 1 partial ⚠️
...ion/src/browser/vscode/api/main.thread.api.impl.ts 58.33% 5 Missing ⚠️
...es/extension/src/browser/extension-node.service.ts 42.85% 4 Missing ⚠️
packages/connection/src/common/rpc/multiplexer.ts 0.00% 2 Missing ⚠️
...ension/src/browser/extension-command-management.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3616      +/-   ##
==========================================
+ Coverage   56.05%   56.09%   +0.04%     
==========================================
  Files        1510     1511       +1     
  Lines       91768    91709      -59     
  Branches    18810    18802       -8     
==========================================
+ Hits        51442    51448       +6     
+ Misses      33454    33387      -67     
- Partials     6872     6874       +2     
Flag Coverage Δ
jsdom 51.51% <72.39%> (+0.03%) ⬆️
node 15.65% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 08cfb84 into main May 6, 2024
13 checks passed
@bytemain bytemain deleted the refactor/ext-protocol-registration branch May 6, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants