This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Identify exact matches pre-dedupe #1568
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/django/api/migrations/0075_add_fli_clean_name_and_address.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Generated by Django 2.2.24 on 2021-12-27 19:40 | ||
|
||
from django.db import migrations, models | ||
from api.matching import clean | ||
|
||
|
||
def populate_cleaned_fields(apps, schema_editor): | ||
FacilityListItem = apps.get_model('api', 'FacilityListItem') | ||
for list_item in FacilityListItem.objects.all(): | ||
list_item.clean_name = clean(list_item.name) | ||
list_item.clean_address = clean(list_item.address) | ||
list_item.save() | ||
|
||
|
||
def do_nothing_on_reverse(apps, schema_editor): | ||
pass | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('api', '0074_embedconfig_prefer_contributor_name'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='facilitylistitem', | ||
name='clean_address', | ||
field=models.CharField(default='', help_text='The cleaned address of the facility.', max_length=200), | ||
), | ||
migrations.AddField( | ||
model_name='facilitylistitem', | ||
name='clean_name', | ||
field=models.CharField(default='', help_text='The cleaned name of the facility.', max_length=200), | ||
), | ||
migrations.AddIndex( | ||
model_name='facilitylistitem', | ||
index=models.Index(fields=['country_code', 'clean_name', 'clean_address'], name='api_fli_match_fields_idx'), | ||
), | ||
migrations.RunPython(populate_cleaned_fields, do_nothing_on_reverse) | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running through the testing instructions, the last list item ended up with 3 match rows. I originally thought this was a problem, but I confirmed that this matches the behavior of the normal deduple process where we would create matches for both a 60% and 90% confidence match but the high quality match would be the
AUTOMATIC
winner. 👍