Skip to content

Commit

Permalink
Fix docker default name unduly set to <svcname> instead of <svcname>.…
Browse files Browse the repository at this point in the history
…<rid>
  • Loading branch information
cvaroqui committed Jul 18, 2018
1 parent b8c937d commit 14e9ce7
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/svcBuilder.py
Expand Up @@ -957,7 +957,7 @@ def add_fs(svc, s):

svc += r

def container_kwargs(svc, s):
def container_kwargs(svc, s, default_name="svcname"):
"""
Common kwargs for all containers.
"""
Expand All @@ -967,7 +967,10 @@ def container_kwargs(svc, s):
try:
kwargs['name'] = svc.conf_get(s, 'name')
except ex.OptNotFound as exc:
kwargs['name'] = svc.svcname
if default_name is None:
kwargs['name'] = exc.default
else:
kwargs['name'] = svc.svcname

try:
kwargs['guestos'] = svc.conf_get(s, 'guestos')
Expand Down Expand Up @@ -1134,7 +1137,7 @@ def add_container_lxc(svc, s):

def add_container_docker(svc, s):
kwargs = init_kwargs(svc, s)
kwargs.update(container_kwargs(svc, s))
kwargs.update(container_kwargs(svc, s, default_name=None))
kwargs['run_image'] = svc.conf_get(s, 'run_image')

try:
Expand Down

0 comments on commit 14e9ce7

Please sign in to comment.