Btrfs sync rewrite #608
Merged
Btrfs sync rewrite #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construct a new dst and switch to it: /opt/opensvc/var/btrfs/bt1.fs.0/.osync/bt1.root.svc.cluster21/sync#0/next => new snaps to send on src, just received on dst /opt/opensvc/var/btrfs/bt1.fs.0/.osync/bt1.root.svc.cluster21/sync#0/last => last snaps correctly send and received /opt/opensvc/var/btrfs/bt1.fs.0/.osync/bt1.root.svc.cluster21/sync#0/temp => where the new dst is assembled before install
* factorize the command passing * store snaps in each <subvol>/.snap/<rfc3339 utc datetime>[,<name>] so users can access the snaps even if shown only the subvol * skip snaps for ro subvolumes (can't create a .snap, and makes no sense to snapshot a immutable dataset)
Because the dst may contain readonly subvols we can remove with rm.
And the extraneous snapshot detection for removal too.
Fix sync_all not triggering the pre_action snaps. Fix a btrfssnap name test.
Display a datetime instead of timestamp in last sync in the "%s older than %s" resource log.
To avoid creating too long shell commands.
Codecov Report
@@ Coverage Diff @@
## b2.1 #608 +/- ##
==========================================
- Coverage 36.62% 36.60% -0.03%
==========================================
Files 354 354
Lines 63081 63246 +165
==========================================
+ Hits 23104 23150 +46
- Misses 39977 40096 +119
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.