Fix purge --local regression #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgalibern
requested review from
arnaudveron and
cvaroqui
and removed request for
cvaroqui
cgalibern
force-pushed
the
fix-817b97660894971e18689393c6090d1a57a901c6
branch
from
025b64d
to
2af7d92
Compare
call_action -> self.setup_environ -> os.environ['OPENSVC_SVC_ID'] = self.id -> create object if object is absent and not self.volatile So after purge/delete action the object is recreated The regression was introduced by #817b97660894971e18689393c6090d1a57a901c6 Reproduce bug with: om foo create om foo purge --local om foo ls
cgalibern
force-pushed
the
fix-817b97660894971e18689393c6090d1a57a901c6
branch
from
2af7d92
to
1b535d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.