Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No luci commotion #11

Merged
merged 2 commits into from
Dec 3, 2013
Merged

No luci commotion #11

merged 2 commits into from
Dec 3, 2013

Conversation

dismantl
Copy link

@dismantl dismantl commented Dec 3, 2013

based on #10 (thanks @tahini !), added small fix.

to test:

  1. flash onto a gateway node
  2. get splashed (go to non-HTTPS site), and make sure both internet and local apps buttons appear
  3. click on internet button and make sure you get redirected to your original request (even if it takes a couple clicks)
  4. enter opkg remove luci-commotion-apps --force-depends; /etc/init.d/nodogsplash stop; sleep 1; /etc/init.d/nodogsplash start
  5. get splashed again and make sure the local apps button is missing

tahini and others added 2 commits November 18, 2013 21:03
* Fix query strings for xhtml themes
* Make the commotion/splash page independent of its parent
* Show apps link only if commotion-apps is installed

Signed-off-by: Geneviève Bastien <gbastien@versatic.net>
@ghost ghost assigned critzo Dec 3, 2013
critzo pushed a commit that referenced this pull request Dec 3, 2013
Tested and confirmed working per pull request test instructions.
@critzo critzo merged commit 86e32fa into master Dec 3, 2013
@critzo critzo deleted the no_luci_commotion branch December 3, 2013 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants