Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh visualizer has the autospacer on by default, but unchecked #175

Closed
georgiamoon opened this issue Feb 27, 2014 · 3 comments
Closed

Mesh visualizer has the autospacer on by default, but unchecked #175

georgiamoon opened this issue Feb 27, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@georgiamoon
Copy link
Member

Preferred: Leave the auto-spacing off by default
Second best: Have the state of the check box match the behavior (either way)

@georgiamoon georgiamoon added this to the 1.1 milestone Feb 28, 2014
@areynold areynold modified the milestone: 1.1 Feb 28, 2014
@areynold
Copy link
Collaborator

@elationfoundation: You mentioned something about auto-spacing being set twice during page creation. Could you remind me of the details?

@seamustuohy
Copy link
Collaborator

The auto-set checkbox in olsr-viz.sh was set off here 8864c55 but, the javascript back-end has auto-spacing set ON by default.

var auto_declump = true; 

Because the checkbox needs to be clicked to activate the set_autodeclump function that controls the auto-spacer it now requires two clicks to unset the auto-spacing.

To fix this issue we must either revert the above commit so that the checkbox accurately reflects the initial state of auto_declump or add our own version of olsr-viz.js to the repository that has auto_declump set to false.

@seamustuohy
Copy link
Collaborator

When #187 is tested, confirmed to work, and merged this issue can be closed.

@areynold areynold closed this as completed Mar 6, 2014
areynold pushed a commit that referenced this issue Mar 6, 2014
Removed default auto-spacing per issue #175

tested by areynold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants