Babel Integration #200
Open
Babel Integration #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if protocol == "commotion" then | ||
| status_builder("commotion/viz", nil, "mesh_visualizer") | ||
| else | ||
| status_builder("commotion/warning_protocol", {proto=protocol}, "mesh_visualizer") |
There was a problem hiding this comment.
Ugh, I am so sorry about the Russian nesting doll status builder process.
If multiple mesh interfaces exist with multiple proto's we want to make sure we show the status of any that we can. The name commotionMesh is only set for the initial mesh interface. If a user creates multiple mesh interfaces, or deletes and recreates their mesh interface it will have another name. The uci:foreach stanza here identifies adhoc wireless interfaces and checks their protocols.
Removed the protocol identification in action_neigh and placed it in its own function so I could also use the same code in the viz function.
A few additions to address some hardcoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Team Réseau Libre & @xbmi
Changes made to the luci-commotion web interface: