[CES] Reimplement Alarm Rules v1 API #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aloento
added
enhancement
Aloento
added
the
need acceptance
Aloento
changed the title
Aloento
removed
the
need acceptance
anton-sidelnikov
requested changes
Aug 4, 2022
|
@anton-sidelnikov @artem-lifshits please review thanks |
outcatcher
suggested changes
Aug 5, 2022
outcatcher
reviewed
Aug 10, 2022
otc-zuul bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
[Refactor] Introduce extract functions What this PR does / why we need it Using extract functions allows to avoid using Result structure and its derivatives Which issue this PR fixes Part of #389 Special notes for your reviewer This is what I was talking about in comments of #389 and in #381 and #384 discussions Also, if unit tests are required, I will provide them later today Reviewed-by: Artem Lifshits <None> Reviewed-by: Aloento <None> Reviewed-by: Anton Sidelnikov <None>
|
@outcatcher @anton-sidelnikov review pls |
outcatcher
reviewed
Aug 12, 2022
outcatcher
previously approved these changes
Aug 12, 2022
anton-sidelnikov
approved these changes
Aug 12, 2022
outcatcher
approved these changes
Aug 12, 2022
|
Build succeeded. ✔️ otc-golangci-lint SUCCESS in 2m 15s |
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Implement Alarm Rules v1 API
Which issue this PR fixes
fixes #378
Special notes for your reviewer