Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CES] Reimplement the MetricData v1 API. #384

Merged
merged 14 commits into from
Aug 12, 2022
Merged

[CES] Reimplement the MetricData v1 API. #384

merged 14 commits into from
Aug 12, 2022

Conversation

Aloento
Copy link
Member

@Aloento Aloento commented Jul 27, 2022 •
edited
Loading

What this PR does / why we need it

Reimplement the MetricData v1 API.

Which issue this PR fixes

Special notes for your reviewer

=== RUN   TestMetricData
    common.go:188: Attempting to create ECSv1
    common.go:201: Created ECSv1 instance: b51bbd3f-1778-41f7-8b0f-a330ce5ddb00
    common.go:207: Attempting to delete ECSv1: b51bbd3f-1778-41f7-8b0f-a330ce5ddb00
    common.go:224: ECSv1 instance deleted: b51bbd3f-1778-41f7-8b0f-a330ce5ddb00
--- PASS: TestMetricData (146.40s)
PASS

@Aloento Aloento added enhancement New feature or request need acceptance Requires running acceptance tests (including cases requiring admin role) labels Jul 27, 2022
@Aloento Aloento self-assigned this Jul 27, 2022
@Aloento Aloento removed the need acceptance Requires running acceptance tests (including cases requiring admin role) label Aug 4, 2022
@Aloento
Copy link
Member Author

Aloento commented Aug 4, 2022 •
edited
Loading

@artem-lifshits @anton-sidelnikov please review thanks

outcatcher
outcatcher suggested changes Aug 5, 2022
View reviewed changes
acceptance/openstack/ces/v1/metricdata_test.go Show resolved Hide resolved
acceptance/openstack/ces/v1/metricdata_test.go Show resolved Hide resolved
openstack/ces/v1/metricdata/requests.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/requests.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/results.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/results.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/results.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/results.go Outdated Show resolved Hide resolved
anton-sidelnikov
anton-sidelnikov requested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@anton-sidelnikov anton-sidelnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me all is ok, i left 2 comment, pls look at it

@outcatcher outcatcher mentioned this pull request Aug 9, 2022
Open
outcatcher
outcatcher suggested changes Aug 9, 2022
View reviewed changes
openstack/ces/v1/metricdata/requests.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/requests.go Outdated Show resolved Hide resolved
openstack/ces/v1/metricdata/requests.go Outdated Show resolved Hide resolved
@outcatcher outcatcher mentioned this pull request Aug 10, 2022
Merged
otc-zuul bot pushed a commit that referenced this pull request Aug 10, 2022
@outcatcher
[Refactor] Introduce extract functions (#391)
e92c6cf 
[Refactor] Introduce extract functions

What this PR does / why we need it
Using extract functions allows to avoid using Result
structure and its derivatives
Which issue this PR fixes

Part of #389
Special notes for your reviewer
This is what I was talking about in comments of #389 and in #381 and #384 discussions
Also, if unit tests are required, I will provide them later today

Reviewed-by: Artem Lifshits <None>
Reviewed-by: Aloento <None>
Reviewed-by: Anton Sidelnikov <None>
@Aloento Aloento added gate Merge PR and removed gate Merge PR labels Aug 11, 2022
@Aloento Aloento requested review from anton-sidelnikov and removed request for anton-sidelnikov August 11, 2022 09:51
@outcatcher outcatcher added gate Merge PR and removed gate Merge PR labels Aug 11, 2022
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Aug 11, 2022

Build failed.
https://zuul.otc-service.com/t/eco/buildset/e98e38a49ada4edb8c564bedbc464fa9

✔️ otc-golangci-lint SUCCESS in 2m 04s
✔️ golang-make-vet SUCCESS in 1m 42s
✔️ golang-make-test SUCCESS in 2m 16s
❌ golang-make-functional FAILURE in 6m 22s

@outcatcher
Copy link
Contributor

outcatcher commented Aug 11, 2022 •
edited
Loading

2022-08-11 14:16:28.506309 | ubuntu-jammy | queues_test.go:34: Failure in queues_test.go, line 34: unexpected error "Expected HTTP response code [201] when accessing [POST https://dms.eu-de.otc.t-systems.com/v1.0/46e3fba075494d1a84aaab83b2297dee/queues], but got 502 instead\n{\"request_id\":\"e6f04a9c3bac7ab403af45cf100cad8e\",\"error_code\":\"APIGW.0201\",\"error_msg\":\"Service DMS is currently unavailable\"}\n" ☹️

@Aloento Aloento added gate Merge PR and removed gate Merge PR labels Aug 12, 2022
@otc-zuul
Copy link
Contributor

otc-zuul bot commented Aug 12, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/173a160bdb7c47ac8a60a71c0c0251ae

✔️ otc-golangci-lint SUCCESS in 2m 26s
✔️ golang-make-vet SUCCESS in 2m 06s
✔️ golang-make-test SUCCESS in 2m 40s
✔️ golang-make-functional SUCCESS in 6m 21s

@otc-zuul otc-zuul bot merged commit 357238e into opentelekomcloud:devel Aug 12, 2022
@Aloento Aloento deleted the metricdata branch August 12, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@lego963 lego963 Awaiting requested review from lego963

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@Aloento Aloento

Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aloento @outcatcher @anton-sidelnikov @artem-lifshits