Add additional check for ALOC as destination address of CoAP request messages. #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 71.69% (diff: 80.00%)@@ master #1164 diff @@
==========================================
Files 128 128
Lines 17631 18792 +1161
Methods 2496 2637 +141
Messages 0 0
Branches 2128 2273 +145
==========================================
+ Hits 12940 13473 +533
- Misses 3890 4455 +565
- Partials 801 864 +63
|
rlubos
reviewed
Jan 17, 2017
| if (((aRequestMetadata.mDestinationAddress == aMessageInfo.GetPeerAddr()) || | ||
| aRequestMetadata.mDestinationAddress.IsMulticast()) && | ||
| (aRequestMetadata.mDestinationPort == aMessageInfo.GetPeerPort())) | ||
| if (aRequestMetadata.mDestinationPort == aMessageInfo.GetPeerPort()) |
There was a problem hiding this comment.
I would consider using IsAnycastRoutingLocator as an additional check for destination address instead of removing address checks.
There was a problem hiding this comment.
I agree. Can we special case the anycast address as the original code did with the multicast address?
There was a problem hiding this comment.
Updated and tested. Please have a check. Thanks.
- Add additional check for ALOC as the destination address of CoAP request messages. - Leader uses RLOC instead of ALOC as source address to response messages.
xiaom-GitHub
force-pushed
the
pr/allow_diff_src_ip_for_coap
branch
from
29475ee
to
8b8c95a
Compare
xiaom-GitHub
changed the title
amejias
pushed a commit
to Zolertia/openthread
that referenced
this pull request
Mar 8, 2017
- Add additional check for ALOC as the destination address of CoAP request messages. - Leader uses RLOC instead of ALOC as source address to response messages.
vaas-krish
pushed a commit
to vaas-krish/openthread
that referenced
this pull request
May 23, 2017
…ub_02712ff to master * commit '6572d839fe0879af1ee11f97902f0193827106c5': Fix a python sniffer stop method (Remove deadlock). (openthread#1163) Python Sniffer Implementation for Windows (openthread#1147) Fix few bugs: (openthread#1164) Fix Route TLV handling during reattach. (openthread#1168) Convert `MeshHeader` constructors to fail-able initializers (openthread#1157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interop with NXP, notice that when OT as commissioner and NXP as Leader, OT sends the MGMT_COMM_SET.req to Leader's ALOC address, NXP node will response CoAP message with its RLOC unicast address, this will cause CoAP message retransmission due to the src/dst address mismatches. (Depends on the port, message id and token, so remove the address comparison). Thus Harness cannot find the correct packets, influences 9.2.2-commissioner and 9.2.4-commissioner. Screenshot as below:
Another enhancement is to select Leader's RLOC unicast address instead of ALOC as source address to response messages. Please have a check.