[platform] attach timestamp in promiscuous mode #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turon
approved these changes
Aug 9, 2018
jwhui
reviewed
Aug 9, 2018
examples/platforms/cc2538/radio.c
Outdated
| sReceiveFrame.mInfo.mRxInfo.mMsec = otPlatAlarmMilliGetNow(); | ||
| sReceiveFrame.mInfo.mRxInfo.mUsec = 0; // Don't support microsecond timer for now. | ||
| #endif | ||
| if (otPlatRadioGetPromiscuous(NULL)) |
There was a problem hiding this comment.
I think it would be better to pass the proper instance, rather than NULL. In this case, sInstance already exists. However, I understand, in some cases below, sInstance does not. Can we update the platform code to maintain sInstance?
jwhui
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sniffing using radio only mode firmware results in packets without timestamp information. This PR attaches timestamp info when in promiscuous mode.