Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update GN build file for OpenThread #5358

Merged
merged 16 commits into from
Aug 12, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Aug 7, 2020

Add the CLI & configuration to the build file.

Add the CLI & configuration to the build file.
@size-report
Copy link

size-report bot commented Aug 7, 2020

Size Report of OpenThread

Merging #5358 into master(f2d0267).

name branch text data bss total
ot-cli-ftd master 398976 736 72772 472484
#5358 398976 736 72772 472484
+/- 0 0 0 0
ot-cli-mtd master 321232 736 64148 386116
#5358 321232 736 64148 386116
+/- 0 0 0 0
ot-ncp-ftd master 392000 736 72052 464788
#5358 392000 736 72052 464788
+/- 0 0 0 0
ot-ncp-mtd master 317648 736 63428 381812
#5358 317648 736 63428 381812
+/- 0 0 0 0
ot-rcp master 63752 636 7512 71900
#5358 63752 636 7512 71900
+/- 0 0 0 0
libopenthread-cli-ftd.a master 39655 0 3548 43203
#5358 39655 0 3548 43203
+/- 0 0 0 0
libopenthread-cli-mtd.a master 32018 0 3548 35566
#5358 32018 0 3548 35566
+/- 0 0 0 0
libopenthread-ftd.a master 196573 4 55060 251637
#5358 196573 4 55060 251637
+/- 0 0 0 0
libopenthread-mtd.a master 132124 4 46436 178564
#5358 132124 4 46436 178564
+/- 0 0 0 0
libopenthread-ncp-ftd.a master 48018 0 2388 50406
#5358 48018 0 2388 50406
+/- 0 0 0 0
libopenthread-ncp-mtd.a master 43210 0 2388 45598
#5358 43210 0 2388 45598
+/- 0 0 0 0
libopenthread-rcp.a master 27043 0 1532 28575
#5358 27043 0 1532 28575
+/- 0 0 0 0
libopenthread-radio.a master 12292 0 150 12442
#5358 12292 0 150 12442
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #5358 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5358      +/-   ##
==========================================
+ Coverage   84.38%   84.49%   +0.10%     
==========================================
  Files         352      353       +1     
  Lines       42923    42993      +70     
==========================================
+ Hits        36220    36326     +106     
+ Misses       6703     6667      -36     
Impacted Files Coverage Δ
src/core/thread/mesh_forwarder.hpp 83.33% <0.00%> (-5.56%) ⬇️
src/core/thread/indirect_sender.cpp 90.04% <0.00%> (-3.80%) ⬇️
examples/platforms/simulation/system.c 80.35% <0.00%> (-1.79%) ⬇️
src/lib/spinel/radio_spinel_impl.hpp 85.11% <0.00%> (-1.40%) ⬇️
src/core/thread/mlr_manager.cpp 94.41% <0.00%> (-0.56%) ⬇️
src/cli/cli_udp.cpp 100.00% <0.00%> (ø)
src/core/thread/mle_tlvs.hpp 100.00% <0.00%> (ø)
src/cli/cli.hpp 100.00% <0.00%> (ø)
src/core/thread/mle.cpp 93.18% <0.00%> (+0.05%) ⬆️
src/core/meshcop/meshcop_tlvs.hpp 85.22% <0.00%> (+0.07%) ⬆️
... and 14 more

@mspang mspang changed the title Update GN build file for OpenThread [build] Update GN build file for OpenThread Aug 7, 2020
@bukepo bukepo requested a review from gjc13 August 10, 2020 00:50
@jwhui jwhui requested a review from bukepo August 11, 2020 22:48
Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@bukepo bukepo requested a review from jwhui August 12, 2020 01:01
@jwhui jwhui changed the title [build] Update GN build file for OpenThread [build] update GN build file for OpenThread Aug 12, 2020
@jwhui jwhui merged commit a24737a into openthread:master Aug 12, 2020
wgtdkp pushed a commit to wgtdkp/openthread that referenced this pull request Sep 11, 2020
Add the CLI & configuration to the build file.
simonlingoogle pushed a commit to simonlingoogle/openthread that referenced this pull request Nov 12, 2020
Bug: 165733525

* origin/github/master:
  [message] add helper methods to get first/next data chunks (openthread#5415)
  [time-ticker] adding 'TimeTicker' class (openthread#5379)
  [ncp] remove left over references to OPENTHREAD_CONFIG_LOG_OUTPUT_NCP_SPINEL (openthread#5427)
  [cmake] use OT_CONFIG for OPENTHREAD_CONFIG_FILE (openthread#5421)
  [github-action] fix coverage uploading for expects (openthread#5423)
  [thread-cert] refactor case 6.2.2 using pktverify (openthread#5353)
  [thread-cert] refactor case 5.5.5 using pktverify (openthread#5332)
  [thread-cert] refactor case 5.5.7 using pktverify (openthread#5313)
  [build] allow custom config file in Android.mk (openthread#5418)
  [extension] add method to receive and handle notifier events (openthread#5420)
  [ip6] simplify `Ip6:Header` and misc. enhancements (openthread#5413)
  [posix] fix potential socket resource leakage (openthread#5405)
  [low-power] add csl feature for Thread 1.2 (openthread#4557)
  [posix] remove unused node id (openthread#5416)
  [cli] fix crash when full logs is on (openthread#5408)
  [thread-cert] refactor case 5.5.4 using pktverify (openthread#5331)
  [mac] change address filter and seek function to accept frame without PAN ID (openthread#5389)
  [efr32] switch to proper config #include style (openthread#5409)
  [udp6] fix 'Udp::Socket::Connect(uint16_t aPort)' (openthread#5407)
  [otns] implement `otPlatOtnsStatus` for posix (openthread#5357)
  [posix] fix typo in error handling on macOS (openthread#5394)
  [non-copyable] remove empty destructor per style guide (openthread#5401)
  [mesh-forwarder] add new class 'ThreadLinkInfo' (openthread#5399)
  [mle] fix FTD unable to restore link to parent (openthread#5301)
  [github-actions] fix otns test failure (openthread#5403)
  [pretty] shfmt only git files (openthread#5395)
  [cli] remove multiple servers support (openthread#5387)
  [netdata] add api to check if joiner is in steering data (openthread#5392)
  [thread-cert] refactor case 5.5.2 using pktverify (openthread#5330)
  [netif] add helper methods to init 'NetifUnicastAddress' (openthread#5390)
  [mle] use helper method 'Mac::GenerateRandomPanId()' (openthread#5391)
  [thread-cert] refactor case 5.8.2 and 5.8.3 using pktverify (openthread#5291)
  [neighbor-table] move "neighbor changed callback" and signaling (openthread#5385)
  [github-actions] run packet verification for multiple times (openthread#5380)
  [build] add missing header in BUILD.gn (neighbor_table.hpp) (openthread#5386)
  [build] update GN build file for OpenThread (openthread#5358)
  [github-action] change the way to upload coverage report (openthread#5375)
  [posix] use raw mode for CLI (openthread#5377)
  [test] add test for router reattach with many routers
  [mle] work around MLE Link Accept messages that are too large
  [mle] log handling parent request failures (openthread#5355)
  [mle] add discovery request callback (openthread#5131)
  [test] only check include/openthread for API version (openthread#5370)
  [mesh-forwarder] simplify 'FragmentPriorityList' (openthread#5374)
  [cli] add cli commands to set unsecure port and link security (openthread#5349)
  [scripts] add packet verification framework (openthread#4428)
  [style] clean up lingering NULL -> nullptr (openthread#5373)
  [cli] add length check on dataset 'set' command (openthread#5361)
  [notifier] simplify how 'Notifier' emits events to core/internal modules (openthread#5365)
  [otns] fix otns status emission built by cmake (openthread#5362)
  [neighbor-table] add 'NeighborTable' class (openthread#5354)
  [topology] adding 'Neighbor::AddressMatcher' (openthread#5354)
Change-Id: Ia4a50753351c4aedcd0d531d27657868d25de7b8
sjlongland pushed a commit to vrtsystems/openthread that referenced this pull request Dec 14, 2022
Add the CLI & configuration to the build file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants