Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[efr32] radio: increase FIFO size to allow handling of heavy traffic #5742

Merged
merged 1 commit into from Oct 29, 2020

Conversation

dismirlian
Copy link
Contributor

This PR increases the FIFO size used for storing the handles of the data request packets that were ACKed with the frame pending bit set. This is a temporary "fix" for #5689; the actual reason for the assert is being investigated by Silabs.

The logic behind the original implementation is here: #4484.

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@size-report
Copy link

size-report bot commented Oct 29, 2020

Size Report of OpenThread

Merging #5742 into master(fc159a7).

name branch text data bss total
ot-cli-ftd_1.1 master 383660 736 72844 457240
#5742 383660 736 72844 457240
+/- 0 0 0 0
ot-cli-mtd_1.1 master 311100 736 64260 376096
#5742 311100 736 64260 376096
+/- 0 0 0 0
ot-ncp-ftd_1.1 master 377564 736 72124 450424
#5742 377564 736 72124 450424
+/- 0 0 0 0
ot-ncp-mtd_1.1 master 307980 736 63540 372256
#5742 307980 736 63540 372256
+/- 0 0 0 0
ot-rcp_1.1 master 64280 636 7656 72572
#5742 64280 636 7656 72572
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 master 38300 0 3108 41408
#5742 38300 0 3108 41408
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.1 master 31119 0 3108 34227
#5742 31119 0 3108 34227
+/- 0 0 0 0
libopenthread-ftd.a_1.1 master 189469 4 54992 244465
#5742 189469 4 54992 244465
+/- 0 0 0 0
libopenthread-mtd.a_1.1 master 129453 4 46408 175865
#5742 129453 4 46408 175865
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 master 48149 0 2388 50537
#5742 48149 0 2388 50537
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.1 master 43345 0 2388 45733
#5742 43345 0 2388 45733
+/- 0 0 0 0
libopenthread-rcp.a_1.1 master 27200 0 1532 28732
#5742 27200 0 1532 28732
+/- 0 0 0 0
libopenthread-radio.a_1.1 master 13406 0 150 13556
#5742 13406 0 150 13556
+/- 0 0 0 0
ot-cli-ftd_1.2 master 407780 736 82392 490908
#5742 407780 736 82392 490908
+/- 0 0 0 0
ot-cli-mtd_1.2 master 323396 736 64544 388676
#5742 323396 736 64544 388676
+/- 0 0 0 0
ot-ncp-ftd_1.2 master 398756 736 81672 481164
#5742 398756 736 81672 481164
+/- 0 0 0 0
ot-ncp-mtd_1.2 master 318244 736 63824 382804
#5742 318244 736 63824 382804
+/- 0 0 0 0
ot-rcp_1.2 master 70956 636 16528 88120
#5742 70956 636 16528 88120
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 master 39949 0 3108 43057
#5742 39949 0 3108 43057
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.2 master 31892 0 3108 35000
#5742 31892 0 3108 35000
+/- 0 0 0 0
libopenthread-ftd.a_1.2 master 210499 4 64440 274943
#5742 210499 4 64440 274943
+/- 0 0 0 0
libopenthread-mtd.a_1.2 master 138920 4 46592 185516
#5742 138920 4 46592 185516
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 master 48149 0 2388 50537
#5742 48149 0 2388 50537
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.2 master 43345 0 2388 45733
#5742 43345 0 2388 45733
+/- 0 0 0 0
libopenthread-rcp.a_1.2 master 27200 0 1532 28732
#5742 27200 0 1532 28732
+/- 0 0 0 0
libopenthread-radio.a_1.2 master 14828 0 174 15002
#5742 14828 0 174 15002
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #5742 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5742   +/-   ##
=======================================
  Coverage   84.91%   84.92%           
=======================================
  Files         376      376           
  Lines       46569    46569           
=======================================
+ Hits        39546    39549    +3     
+ Misses       7023     7020    -3     
Impacted Files Coverage Δ
src/core/thread/mesh_forwarder.cpp 91.81% <0.00%> (-1.43%) ⬇️
src/core/thread/mesh_forwarder_ftd.cpp 87.75% <0.00%> (-0.52%) ⬇️
src/core/thread/mle.cpp 93.63% <0.00%> (-0.06%) ⬇️
src/core/thread/mle_router.cpp 90.37% <0.00%> (-0.06%) ⬇️
src/core/meshcop/meshcop_tlvs.hpp 85.71% <0.00%> (+0.49%) ⬆️
src/core/meshcop/joiner_router.cpp 92.02% <0.00%> (+0.53%) ⬆️
src/lib/spinel/radio_spinel_impl.hpp 88.71% <0.00%> (+1.72%) ⬆️

Copy link
Member

@suveshpratapa suveshpratapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit 1586c4c into openthread:master Oct 29, 2020
@dismirlian dismirlian deleted the ackfp branch November 1, 2020 18:37
simonlingoogle pushed a commit to simonlingoogle/openthread that referenced this pull request Nov 12, 2020
Bug: 171933690

* origin/github/master:
  [low-power] implement forward tracking series (openthread#5608)
  [efr32] radio: increase FIFO size to allow handling of heavy traffic (openthread#5742)
  [test] verify realm-local multicast on POSIX (openthread#5738)
  [clang-tidy] google-explicit-constructor (openthread#5734)
  [clang-tidy] misc-unused-using-decls (openthread#5732)
  [continuous-integration] use lcov to generate coverage data (openthread#5635)
  [type-traits] add 'IsPointer<Type>' and use it in message/dataset (openthread#5735)
  [posix] set default IPv6 hop limit to OPENTHREAD_CONFIG_IP6_HOP_LIMIT_DEFAULT (openthread#5736)
  [net-diag] invoke the callback when failed to get the response (openthread#5653)
  [site] fix border router guide typo in network (openthread#5731)
  [cli] update cli doc (openthread#5729)
  [thread-cert] refactor case 5.1.3 using pktverify (openthread#5708)
  [thread-cert] refactor case 5.1.2 using pktverify (openthread#5686)
  [test] arm build with cmake 3.10 (openthread#5727)
  [clang-tidy] google-readability-casting (openthread#5720)
  [clang-tidy] modernize-use-equals-default (openthread#5719)
  [clang-tidy] readability-avoid-const-params-in-decls (openthread#5717)
  [clang-tidy] modernize-use-equals-delete (openthread#5718)
  [efr32] add MG21/BRD4180B support (openthread#5725)
  [posix] fix cast-align build error on ARM (openthread#5672)
  [logging] add optional `otPlatLogLine()` & use it in NCP/CLI (openthread#5704)
  [clang-tidy] readability-simplify-boolean-expr (openthread#5716)
  [clang-tidy] modernize-use-nullptr (openthread#5715)
  [dataset] add new helper 'SetTlv()' with a template 'ValueType' (openthread#5722)
  [dataset-manager] simplify 'SendSetRequest()' (openthread#5721)
  [nrf528xx] fix SPI issue (openthread#5703)
  [clang-tidy] modernize-use-bool-literals (openthread#5714)
  [cmake] no target_link_options in cmake 3.10 (openthread#5706)
  [low-power] enhance CSL transmission on NRF52840 using `transmit_at` (openthread#5545)
  [build] fix warning of clearing non-trivial type (openthread#5710)
  [scripts] add MLR Backbone multicast routing test (openthread#5578)
  [mlr] fix build when OPENTHREAD_CONFIG_IP6_SLAAC_ENABLE is disabled (openthread#5711)
  [cmake] use init flags in toolchain files (openthread#5705)
  [cmake] set default build type to Debug (openthread#5709)
  [thread-cert] refactor case 5.1.1 using pktverify (openthread#5680)
  [posix] fix udp close (openthread#5690)
Change-Id: Ic7e4051040f093aa6dce9de5e2031a8accddec87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants