Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ip6] always deliver multicast to host #9824

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bukepo
Copy link
Member

@bukepo bukepo commented Feb 2, 2024

This commit always delivers multicast traffic to the host.

Without this change, host will not be able to receive link-local and mesh-local multicast traffic, even the host subscribes to some multicast addresses in these scopes.

Note that this does not change the host forwarding rules, as link-local and mesh-local traffic are not supposed to be forwarded to adjacent links.

This commit always delivers multicast traffic to host.

Without this change, host will not be able to receive link-local and
mesh-local multicast traffic, even the host subscribes to some multicast
addresses in these scopes.

Note that this does not change the host forwarding rules, as link-local and
mesh-local traffic are not supposed to be forwarded to adjacent links.
@bukepo bukepo requested review from abtink and jwhui February 2, 2024 06:38
@bukepo
Copy link
Member Author

bukepo commented Feb 2, 2024

Divided from #9817. Solves project-chip/connectedhomeip#31681

Copy link

size-report bot commented Feb 2, 2024

Size Report of OpenThread

Merging #9824 into main(21cd366).

name branch text data bss total
ot-cli-ftd main 464768 760 66284 531812
#9824 464752 760 66284 531796
+/- -16 0 0 -16
ot-ncp-ftd main 434828 760 61496 497084
#9824 434812 760 61496 497068
+/- -16 0 0 -16
libopenthread-ftd.a main 234092 0 40230 274322
#9824 234076 0 40230 274306
+/- -16 0 0 -16
libopenthread-cli-ftd.a main 56861 0 8075 64936
#9824 56861 0 8075 64936
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 31839 0 5916 37755
#9824 31839 0 5916 37755
+/- 0 0 0 0
ot-cli-mtd main 363928 760 51180 415868
#9824 363896 760 51180 415836
+/- -32 0 0 -32
ot-ncp-mtd main 346556 760 46408 393724
#9824 346540 760 46408 393708
+/- -16 0 0 -16
libopenthread-mtd.a main 157478 0 25142 182620
#9824 157450 0 25142 182592
+/- -28 0 0 -28
libopenthread-cli-mtd.a main 39720 0 8059 47779
#9824 39720 0 8059 47779
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 24719 0 5916 30635
#9824 24719 0 5916 30635
+/- 0 0 0 0
ot-cli-ftd-br main 533152 768 130964 664884
#9824 533136 768 130964 664868
+/- -16 0 0 -16
libopenthread-ftd-br.a main 297081 5 104886 401972
#9824 297065 5 104886 401956
+/- -16 0 0 -16
libopenthread-cli-ftd-br.a main 70494 0 8099 78593
#9824 70494 0 8099 78593
+/- 0 0 0 0
ot-rcp main 62232 564 20604 83400
#9824 62232 564 20604 83400
+/- 0 0 0 0
libopenthread-rcp.a main 9534 0 5052 14586
#9824 9534 0 5052 14586
+/- 0 0 0 0
libopenthread-radio.a main 18815 0 214 19029
#9824 18815 0 214 19029
+/- 0 0 0 0

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21cd366) 86.39% compared to head (a81c6a3) 84.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9824      +/-   ##
==========================================
- Coverage   86.39%   84.91%   -1.48%     
==========================================
  Files         555      558       +3     
  Lines       70069    70574     +505     
==========================================
- Hits        60535    59927     -608     
- Misses       9534    10647    +1113     
Files Coverage Δ
src/core/net/ip6.cpp 79.20% <100.00%> (-1.93%) ⬇️

... and 98 files with indirect coverage changes

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

@jwhui jwhui merged commit 74c833b into openthread:main Feb 2, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants