[test] refactor d-bus test #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukepo
force-pushed
the
refactor-dbus-test
branch
from
7f353a7
to
88cbde3
Compare
bukepo
force-pushed
the
refactor-dbus-test
branch
from
88cbde3
to
0d0ead0
Compare
This commit refactors the d-bus client test: 1. use systemd to manage the otbr-agent service so that setsid is not necessary which requires inputting user password running locally 2. simplify tests by adding ot_ctl and factoryreset function 3. clean up main function by moving test cases into separate functions This commit also * adds missing *Ready* signal in introspect.xml * fixes path to factory conf file
bukepo
force-pushed
the
refactor-dbus-test
branch
from
0d0ead0
to
47a2cbb
Compare
jwhui
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the d-bus client test:
Other updates: