-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ncp] rename ControllerOpenThread
to RcpHost
#2294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
===========================================
- Coverage 55.77% 39.76% -16.01%
===========================================
Files 87 88 +1
Lines 6890 9779 +2889
Branches 0 721 +721
===========================================
+ Hits 3843 3889 +46
- Misses 3047 5692 +2645
- Partials 0 198 +198 ☔ View full report in Codecov by Sentry. |
c956316
to
7893479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7893479
to
f782be3
Compare
f782be3
to
5a0a904
Compare
5a0a904
to
4802e7b
Compare
4802e7b
to
35a1c35
Compare
ControllerOpenThread
to RcpHost
ControllerOpenThread
to RcpHost
ControllerOpenThread
to RcpHost
This PR does a few renaming for
ControllerOpenThread
:ncp_openthread.*
torcp_host.*
mNcp
tomHost
and all theparameters
aNcp
toaHost
.ControllerOpenThread
toRcpHost
.Currently the
ControllerOpenThread
actually works under RCP mode.So the name
Ncp
is very confusing.RcpHost
is usedin this PR so that we can later add
NcpHost
.This PR is a subset of PR #2283 and only does some renaming.