Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] rename ControllerOpenThread to RcpHost #2294

Merged
merged 1 commit into from
May 24, 2024

Conversation

Irving-cl
Copy link
Contributor

@Irving-cl Irving-cl commented May 22, 2024

This PR does a few renaming for ControllerOpenThread:

  1. Rename file ncp_openthread.* to rcp_host.*
  2. Rename all the member variable mNcp to mHost and all the
    parameters aNcp to aHost.
  3. Rename the class ControllerOpenThread to RcpHost.

Currently the ControllerOpenThread actually works under RCP mode.
So the name Ncp is very confusing. RcpHost is used
in this PR so that we can later add NcpHost.

This PR is a subset of PR #2283 and only does some renaming.

@Irving-cl Irving-cl marked this pull request as ready for review May 22, 2024 02:38
@Irving-cl Irving-cl changed the title [controller] refactor and rename Controller Openthread [controller] rename Controller Openthread May 22, 2024
Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 40.25974% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 39.76%. Comparing base (2b41187) to head (35a1c35).
Report is 665 commits behind head on main.

Files Patch % Lines
src/dbus/server/dbus_thread_object.cpp 9.09% 70 Missing ⚠️
src/border_agent/border_agent.cpp 53.84% 6 Missing ⚠️
src/sdp_proxy/discovery_proxy.cpp 33.33% 6 Missing ⚠️
src/ncp/rcp_host.cpp 81.81% 4 Missing ⚠️
src/trel_dnssd/trel_dnssd.cpp 40.00% 3 Missing ⚠️
src/rest/resource.cpp 60.00% 2 Missing ⚠️
src/utils/thread_helper.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2294       +/-   ##
===========================================
- Coverage   55.77%   39.76%   -16.01%     
===========================================
  Files          87       88        +1     
  Lines        6890     9779     +2889     
  Branches        0      721      +721     
===========================================
+ Hits         3843     3889       +46     
- Misses       3047     5692     +2645     
- Partials        0      198      +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/backbone_router/backbone_agent.hpp Outdated Show resolved Hide resolved
src/openwrt/ubus/otubus.hpp Outdated Show resolved Hide resolved
src/dbus/server/dbus_thread_object.hpp Outdated Show resolved Hide resolved
src/sdp_proxy/discovery_proxy.hpp Outdated Show resolved Hide resolved
src/trel_dnssd/trel_dnssd.hpp Outdated Show resolved Hide resolved
src/utils/thread_helper.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl requested a review from superwhd May 23, 2024 02:34
src/agent/main.cpp Outdated Show resolved Hide resolved
src/dbus/server/dbus_thread_object.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the rename_openthread_controller branch from c956316 to 7893479 Compare May 23, 2024 03:21
@Irving-cl Irving-cl requested a review from superwhd May 23, 2024 03:21
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl force-pushed the rename_openthread_controller branch from 7893479 to f782be3 Compare May 23, 2024 04:30
@Irving-cl Irving-cl force-pushed the rename_openthread_controller branch from f782be3 to 5a0a904 Compare May 24, 2024 01:25
@Irving-cl Irving-cl requested a review from jwhui May 24, 2024 01:31
@Irving-cl Irving-cl force-pushed the rename_openthread_controller branch from 5a0a904 to 4802e7b Compare May 24, 2024 01:44
@Irving-cl Irving-cl force-pushed the rename_openthread_controller branch from 4802e7b to 35a1c35 Compare May 24, 2024 02:18
@jwhui jwhui changed the title [controller] rename Controller Openthread [controller] rename ControllerOpenThread to RcpHost May 24, 2024
@jwhui jwhui changed the title [controller] rename ControllerOpenThread to RcpHost [ncp] rename ControllerOpenThread to RcpHost May 24, 2024
@jwhui jwhui merged commit dc226f4 into openthread:main May 24, 2024
30 checks passed
@Irving-cl Irving-cl deleted the rename_openthread_controller branch June 1, 2024 09:04
@Irving-cl Irving-cl mentioned this pull request Jul 23, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants