[controller] replace reference of controller with pointer #2299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the reference of
Ncp::HostRcp
inside all modulesto a pointer to
Ncp::HostRcp
. Instead of passing the reference ofNcp::HostRcp
to all modules in their contructors, this PR changesit as passing a pointer in the
Init
of these modules.This PR is also a subset of #2283. This change is required because:
Currently there is an instance of
Ncp::HostRcp
as a member of themain class
Application
. Most modules insideApplication
have areference to the instance and the reference is passed to these modules
in their constructor (in
Application
's initialization list).However, in the NCP case,
Ncp::HostRcp
shouldn't be contructed atall. So updating the reference to pointer allows
Application
to notinitialize these modules in NCP case and initialize a different
Host
.