feat: augments

[phacUFPE]

Description

Implementing Augments system.
Please check the system in the following links:
https://tibia.fandom.com/wiki/Augments
https://www.tibia.com/news/?subtopic=newsarchive&id=7356

What must be done:

• Add augments to all items that have it;
• Parse augments from items.xml;
• Add default value from config lua for augments without value;
• Store augments into item;
• Show augments on market;
• Display augments on item look;
• Apply augments cooldown on spell usage;
• Apply augments that increase damage on spell usage;
• Apply augments life/mana leech on spell usage;
• Test against players (I ask for the community help to test);
• Test against monsters (I ask for the community help to test).

Suggestions are welcome.

How to configure an item augment:

Supported augment types are:

• "critical extra damage",
• "life leech",
• "mana leech",
• "cooldown",
• "increased damage", (don't need to set value, but can be customized for a specific item)
• "strong impact", (don't need to set value, but can be customized for a specific item)
• "powerful impact" (don't need to set value, but can be customized for a specific item)

Example of augment that have default value::

<attribute key="augments" value="1">
	<attribute key="spell name" value="augment type" />
</attribute>

NOTE: The key value of the key "augments" is to enable (1) and disable (0) the augments of the item.

Example of augment that don't have default value, the value must be set:

NOTE: The values represent percentagel, except for cooldown, it should be fill in miliseconds (120 seconds = 120000).

<attribute key="augments" value="1">
   <attribute key="energy wave" value="life leech">
     <attribute key="value" value="5" />
   </attribute>
</attribute>

How to customize an augment that already has a default value?

Just add attribute tag with the key value and the value that you which, example:

<attribute key="augments" value="1">
   <attribute key="energy wave" value="powerful impact">
     <attribute key="value" value="15" />
   </attribute>
</attribute>

[luanluciano93]

https://github.com/opentibiabr/canary/blob/main/src/items/functions/item/item_parse.cpp#L80

ItemParse::parseAugment(tmpStrValue, attributeNode, valueAttribute, itemType);

in parse

canary/src/items/functions/item/item_parse.hpp

Line 249 in 9f74b27

const phmap::flat_hash_map<std::string, AugmentsTypes_t> AugmentsTypeMap = {
	{ "powerful impact", AUGMENT_VALUE_POWERFUL_IMPACT },
	{ "strong impact", AUGMENT_VALUE_STRONG_IMPACT },
	{ "increased damage", AUGMENT_VALUE_INCREASED_DAMAGE },
	{ "cooldown", AUGMENT_VALUE_COOLDOWN },
	{ "critical extra damage", AUGMENT_VALUE_CRITICALHITDAMAGE },
	{ "life leech", AUGMENT_VALUE_LIFELEECHAMOUNT },
	{ "mana leech", AUGMENT_VALUE_MANALEECHAMOUNT },
};

[phacUFPE]

Update!

Item parse working and storing into item.

[phacUFPE]

Update!

Added item description.

[phacUFPE]

Update!

Added augments to all sanguine and grand sanguine items.

[phacUFPE]

Update!

Added augments descriptions on market.

[phacUFPE]

Update!

Cooldown augments working (except for avatar, avatar spells cooldown are calculated in the casting, after this PR I'll be investigating to fix it).

2024-05-04.08-52-14.mp4

[dudantas]

I have a few suggestions that could enhance performance and address other issues. Please remember to test these changes before implementing them, as my review is based solely on the code, and I haven’t applied them locally. Additional adjustments might be necessary to prevent compilation errors.

I will conduct the review in a way that locks the PR, because some modifications are optional, while others, like unnecessary copying that directly impacts performance, or dividing by zero without checking the divisor, could potentially cause more serious issues. Feel free to reach out to me for another review when you're ready.

[phacUFPE]

I have a few suggestions that could enhance performance and address other issues. Please remember to test these changes before implementing them, as my review is based solely on the code, and I haven’t applied them locally. Additional adjustments might be necessary to prevent compilation errors.

I will conduct the review in a way that locks the PR, because some modifications are optional, while others, like unnecessary copying that directly impacts performance, or dividing by zero without checking the divisor, could potentially cause more serious issues. Feel free to reach out to me for another review when you're ready.

All fixed and working as expected.