Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avatar cooldown reduction #2607

Merged
merged 5 commits into from
May 12, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented May 6, 2024

Description

This PR fixes the avatar cooldown reduction spells to be done in the source and remove from scripts, this is being done to work with #2602.

Behaviour

Actual

The avatar cooldown reduction is via script.

Expected

The avatar cooldown reduction is via source.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Cast Avatar spell of each vocation with stage 1 in wheel, the cooldown should be 120 minutes (two hours)
  • Cast Avatar spell of each vocation with stage 2 in wheel, the cooldown should be 90 minutes (one and a half hour)
  • Cast Avatar spell of each vocation with stage 3 in wheel, the cooldown should be 60 minutes (one hour)

Test Configuration:

  • Server Version: Latest
  • Client: 13.32
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

phacUFPE and others added 2 commits May 6, 2024 03:58
changes:
- Updated to the correct value the avatar spells cooldown reduction
- Removed from spell scripts the cooldown reduction
@phacUFPE phacUFPE mentioned this pull request May 6, 2024
11 tasks
jprzimba added a commit to jprzimba/crystalserver that referenced this pull request May 6, 2024
jbracovich

This comment was marked as spam.

@phacUFPE phacUFPE merged commit a9360fa into opentibiabr:main May 12, 2024
33 checks passed
@phacUFPE phacUFPE deleted the fix_avatar_cooldown_reduction branch May 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants