[Feature] Item tiers and new skills (Onslaught, Ruse and Momentum) from 12.80

[omeranha]

The forge system part will be completed in another pull request, and focused after I finish these!
Continuation of this pull request will be in the forge, follow the link: #543

New Item Tiers and classifications

Added functions
item:getTier()
item:addTier(tier)

need a tiered item?
use the commited script, you can copy to OTservBR-Global datapack if you want

New skills

All informations avaliable in Tibia Fandom
Onslaught(Fatal): https://tibia.fandom.com/wiki/Onslaught
Ruse(block hits): https://tibia.fandom.com/wiki/Ruse
Momentum(cooldown reduction): https://tibia.fandom.com/wiki/Momentum

Missing

• Missing some item tier bytes.
• Market saving tier attribute.
  and more, much more things.

Type of change

• New feature (non-breaking change which adds functionality)

[guispiller]

Found a new issue on market related to tiers. How to reproduce, with an example of Plate armor (you can use any item).

1 - create a buy offer of a plate armor tier 0 with Player A.
2 - Get 1 Plate armor Tier 1 on first slot of a depot box, and one plate armor Tier 0 at the second slot of the same depot box.
3 - Sell the plate armor tier 0 to the buy offer at the market.

Result: As the first slot is the Tier 1 armor, this one will be sold. So, player A will receive a Tier 0 armor, and player B will sell a Tier 1 armor.
This can occur also if there are tiered items of the same at mailbox, and lower tiered on depot box. It is not checking the tier, it's just selling the first one

[dudantas]

Found a new issue on market related to tiers. How to reproduce, with an example of Plate armor (you can use any item).

1 - create a buy offer of a plate armor tier 0 with Player A. 2 - Get 1 Plate armor Tier 1 on first slot of a depot box, and one plate armor Tier 0 at the second slot of the same depot box. 3 - Sell the plate armor tier 0 to the buy offer at the market.

Result: As the first slot is the Tier 1 armor, this one will be sold. So, player A will receive a Tier 0 armor, and player B will sell a Tier 1 armor. This can occur also if there are tiered items of the same at mailbox, and lower tiered on depot box. It is not checking the tier, it's just selling the first one

Thanks for reporting. Please, test this commit: d0d3482

I tested it, and it seems to have fixed the problem.

[tutbarao]

I found a bug: Cannot cancel market offers. When you click the cancel button, nothing happens.

[tutbarao]

I got this error when starting the server. Perhaps this is the cause of the above bug.

[dudantas]

I got this error when starting the server. Perhaps this is the cause of the above bug.

Fixed with last commit (ec64bb5), thanks for reporting

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
25 Code Smells

0.0% Coverage
0.3% Duplication

[travisani]

Tem que ver se não vai crashar / debugar combinando:
Critical + Fatal (tier)
Dodge (tier) + Critical

Durante battle com monstros que refletem dano ou absorvam dano. ex; Burster Spectre ou Bosses refletindo ao mesmo tempo em que o tier gera um possivel dodge.
Com imbuements ou Runas de Aumento de mana/life leech e/ou Critico (Low Blow)

Fora outras combinações que não me vem a cabeça agora 😵‍💫

[dudantas]

Pull finished, it was tested in several scenarios, by several people, what was reported has already been fixed and now we can merge.

[dudantas]

Tem que ver se não vai crashar / debugar combinando: Critical + Fatal (tier) Dodge (tier) + Critical

Durante battle com monstros que refletem dano ou absorvam dano. ex; Burster Spectre ou Bosses refletindo ao mesmo tempo em que o tier gera um possivel dodge. Com imbuements ou Runas de Aumento de mana/life leech e/ou Critico (Low Blow)

Fora outras combinações que não me vem a cabeça agora 😵‍💫

Nós já estamos trabalhando no pull request há um bom tempo e resolvemos tudo que foi reportado e o que encontramos de bug. Se você quiser testar este cenário e informar se deu algum problema, é de bom grado. Particularmente eu não tenho interesse em realizar este teste. Caso tenha interesse, é só reportar no pull request da forja, este já vai para o merge...

[dudantas]

Continuation of this pull request will be in the forge, follow the link: #543