Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash related to on look item #456

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Fix crash related to on look item #456

merged 3 commits into from
Jul 26, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Jul 25, 2022 •
edited

@dudantas dudantas requested a review from guispiller July 25, 2022 16:26
@dudantas dudantas linked an issue Jul 25, 2022 that may be closed by this pull request
Canary 1.4.0 - NPC crash server #455
Closed
5 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit a40f216 into main Jul 26, 2022
@dudantas dudantas deleted the fix-crash-related-to-look-item branch July 26, 2022 00:40
luan pushed a commit that referenced this pull request Jul 11, 2023
@dudantas
Fix crash related to item show attributes description (#456)
7e0c03c 
Removed reference from item and added pointer nullptr check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guispiller guispiller guispiller approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
Canary Roadmap
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canary 1.4.0 - NPC crash server high ram memory usage
3 participants
@dudantas @guispiller @majestyotbr