Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: imbued item does not start the imbuement timer countdown #475

Merged
merged 4 commits into from
Jan 10, 2023
Merged

fix: imbued item does not start the imbuement timer countdown #475

merged 4 commits into from
Jan 10, 2023

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Aug 1, 2022

Resolves #467

@dudantas dudantas mentioned this pull request Aug 1, 2022
Closed
5 tasks
@dudantas dudantas changed the title Imbued item won't start the imbuement timer countdown Fixed imbued item not start the imbuement timer countdown Aug 1, 2022
gerotib
gerotib approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@gerotib gerotib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems fine now

@dudantas
Copy link
Contributor Author

dudantas commented Aug 1, 2022

Tested and seems fine now

Thanks for send feedback!

CleberMoreira
CleberMoreira reviewed Aug 1, 2022
View reviewed changes
Copy link

@CleberMoreira CleberMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! I imbued an Soulcrusher with lifesteal hunted for a few minutes and it was still 20:00 hours of imbuement left!

@gerotib
Copy link
Contributor

gerotib commented Aug 1, 2022

@CleberMoreira Does the timer start if you imbue unequpped item and then equip it? Or maybe you had no "infight" mode (sword icon)

@dudantas
Copy link
Contributor Author

dudantas commented Aug 1, 2022

@CleberMoreira Does the timer start if you imbue unequpped item and then equip it? Or maybe you had no "infight" mode (sword icon)

I tested it and when I imbue the item with it equipped it really isn't decaying, it only resolved when I imbue it with it unequipped

@dudantas
Copy link
Contributor Author

dudantas commented Aug 3, 2022 •
edited

Apparently some items decay, others don't. I'm trying to find the pattern. It seems that only the first imbued item after login decays, on imbuing another item it no longer decays.

@dudantas
Copy link
Contributor Author

dudantas commented Aug 3, 2022

@gerotib I sent one more commit that should solve the problem, can you test again?

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gerotib
Copy link
Contributor

gerotib commented Aug 4, 2022

@dudantas it doesn't start the timer now. With only first commit it sometimes did and sometimes didnt, I tried to find a way to reproduce, but I really dont get it

@dudantas
Copy link
Contributor Author

dudantas commented Aug 4, 2022

@dudantas it doesn't start the timer now. With only first commit it sometimes did and sometimes didnt, I tried to find a way to reproduce, but I really dont get it

I'll have to investigate a bit more about this, I'm also having trouble understanding.

@dudantas dudantas marked this pull request as draft August 16, 2022 01:41
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Sep 15, 2022
@github-actions github-actions bot removed the Stale No activity label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 3, 2022
@156323233
Copy link

Hello, I'm not sure if this PR is still open and being investigated, but I'm using the latest Canary version and I noticed that the imbuement countdown stops counting only after the 60min automatic server save, I've tested many times and it always happens after the ss.

@github-actions github-actions bot removed the Stale No activity label Jan 3, 2023
@dudantas
Copy link
Contributor Author

dudantas commented Jan 8, 2023

@156323233 @gerotib @CleberMoreira please test again

@dudantas dudantas marked this pull request as ready for review January 8, 2023 08:15
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

carlospess0a
carlospess0a approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@carlospess0a carlospess0a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! Worked as expected.

@dudantas dudantas merged commit 340a76d into main Jan 10, 2023
@dudantas dudantas deleted the fix-imbuement-decay-time branch January 10, 2023 00:03
@cojucoti
Copy link

@dudantas I have introduced this fix, but, apart from the fact that the imbuiments don't work (they don't give critical, mana, life) even if you don't have the weapon equipped and you have PZ, it lowers your CD.

@cojucoti cojucoti mentioned this pull request Jan 15, 2023
Closed
5 tasks
jacksonie pushed a commit to jacksonie/canary that referenced this pull request Feb 17, 2023
@dudantas @jacksonie
[Bug] fixes imbued item not start the imbuement timer countdown (open…
35023dc 
…tibiabr#475)
luan pushed a commit that referenced this pull request Jul 11, 2023
@dudantas
[Bug] fixes imbued item not start the imbuement timer countdown (#475)
91c162f
@dudantas dudantas changed the title Fixed imbued item not start the imbuement timer countdown fix: imbued item does not start the imbuement timer countdown Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleberMoreira CleberMoreira CleberMoreira left review comments

@carlospess0a carlospess0a carlospess0a approved these changes

@gerotib gerotib gerotib approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
Canary Roadmap
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imbuing equipped item won't start the imbu timer countdown
7 participants
@dudantas @gerotib @156323233 @cojucoti @carlospess0a @majestyotbr @CleberMoreira