-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: imbued item does not start the imbuement timer countdown #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems fine now
Thanks for send feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! I imbued an Soulcrusher with lifesteal hunted for a few minutes and it was still 20:00 hours of imbuement left!
@CleberMoreira Does the timer start if you imbue unequpped item and then equip it? Or maybe you had no "infight" mode (sword icon) |
I tested it and when I imbue the item with it equipped it really isn't decaying, it only resolved when I imbue it with it unequipped |
Apparently some items decay, others don't. I'm trying to find the pattern. It seems that only the first imbued item after login decays, on imbuing another item it no longer decays. |
@gerotib I sent one more commit that should solve the problem, can you test again? |
Kudos, SonarCloud Quality Gate passed! |
@dudantas it doesn't start the timer now. With only first commit it sometimes did and sometimes didnt, I tried to find a way to reproduce, but I really dont get it |
I'll have to investigate a bit more about this, I'm also having trouble understanding. |
This PR is stale because it has been open 45 days with no activity. |
This PR is stale because it has been open 45 days with no activity. |
Hello, I'm not sure if this PR is still open and being investigated, but I'm using the latest Canary version and I noticed that the imbuement countdown stops counting only after the 60min automatic server save, I've tested many times and it always happens after the ss. |
@156323233 @gerotib @CleberMoreira please test again |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! Worked as expected.
@dudantas I have introduced this fix, but, apart from the fact that the imbuiments don't work (they don't give critical, mana, life) even if you don't have the weapon equipped and you have PZ, it lowers your CD. |
Resolves #467