Adding verification to prevent crash #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
Dec 19, 2022
dudantas
reviewed
Dec 19, 2022
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
|
SonarCloud Quality Gate failed. |
beats-dh
approved these changes
Dec 20, 2022
3 tasks
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Check if the container is nullptr before accessing its methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding verification to prevent crash
Details
Thread 2 "canary" received signal SIGSEGV, Segmentation fault.
2022-12-19 15:32:19 - [Switching to Thread 0x7ffff79ac700 (LWP 117106)]
2022-12-19 15:32:19 - 0x00005555556e888c in Player::postAddNotification (this=0x7fffb02bb680, thing=, oldParent=, index=, link=) at /home/xxx/src/creatures/players/player.cpp:3870
2022-12-19 15:32:19 - 3870 if (!Position::areInRange<1, 1, 0>(container->getPosition(), getPosition())) {