This repository has been archived by the owner on May 20, 2023. It is now read-only.
[Enhancement] Protocol update to 12.91 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guispiller
changed the title
fluizvitor
approved these changes
Aug 18, 2022
|
What do you think to use tables as parameters to avoid mass updates in npc's? npcType.onBuyItem = function(npc, player, itemId, subType, amount, ignore, inBackpacks, totalCost) to npcType.onBuyItem = function(npcParameters) npcParameters.npc |
This was referenced Aug 29, 2022
5 tasks
This reverts commit dff6ef5.
majestyotbr
changed the title
majestyotbr
approved these changes
Sep 13, 2022
dudantas
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update datapack items and npcs to protocol 12.91;
Changed some monster's loot names to ID to avoid conflict;
Inserted some Marapur monsters by @carlospess0a and @JohneVictor
Inserted transformto logics of items.
This PR works directly with Canary opentibiabr/canary#443.
If you are interested in testing 12.90 items with their special skills, you could use this PR with opentibiabr/canary#366 and remove the comment from attributes on items.xml.
Type of change
Please delete options that are not relevant.