Mark OpReverse as pending depreciation

opentimestamps · Sep 5, 2016 · ff2ab8a · ff2ab8a
1 parent 1d7de29
commit ff2ab8a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/opentimestamps/core/op.py b/opentimestamps/core/op.py
@@ -174,6 +174,8 @@ class OpReverse(UnaryOp):
     TAG_NAME = 'reverse'
 
     def __call__(self, msg):
+        import warnings
+        warnings.warn("OpReverse may get removed; see https://github.com/opentimestamps/python-opentimestamps/issues/5", PendingDeprecationWarning)
         return msg[::-1]
 
 

diff --git a/opentimestamps/tests/core/test_op.py b/opentimestamps/tests/core/test_op.py
@@ -22,9 +22,9 @@ def test_prepend(self):
         """Prepend operation"""
         self.assertEqual(OpPrepend(b'prefix')(b'msg'), b'prefixmsg')
 
-    def test_reverse(self):
-        """Reverse operation"""
-        self.assertEqual(OpReverse()(b'abcd'), b'dcba')
+#    def test_reverse(self):
+#        """Reverse operation"""
+#        self.assertEqual(OpReverse()(b'abcd'), b'dcba')
 
     def test_sha256(self):
         """SHA256 operation"""

diff --git a/opentimestamps/tests/core/test_timestamp.py b/opentimestamps/tests/core/test_timestamp.py
@@ -20,12 +20,12 @@ class Test_Timestamp(unittest.TestCase):
     def test_add_op(self):
         """Adding operations to timestamps"""
         t = Timestamp(b'abcd')
-        t.ops.add(OpReverse())
-        self.assertEqual(t.ops[OpReverse()], Timestamp(b'dcba'))
+        t.ops.add(OpAppend(b'efgh'))
+        self.assertEqual(t.ops[OpAppend(b'efgh')], Timestamp(b'abcdefgh'))
 
-        # The second add should succeed
-        t.ops.add(OpReverse())
-        self.assertEqual(t.ops[OpReverse()], Timestamp(b'dcba'))
+        # The second add should succeed with the timestamp unchanged
+        t.ops.add(OpAppend(b'efgh'))
+        self.assertEqual(t.ops[OpAppend(b'efgh')], Timestamp(b'abcdefgh'))
 
     def test_set_result_timestamp(self):
         """Setting an op result timestamp"""
@@ -42,10 +42,10 @@ def test_set_result_timestamp(self):
     def test_set_fail_if_wrong_message(self):
         """Setting an op result timestamp fails if the messages don't match"""
         t = Timestamp(b'abcd')
-        t.ops.add(OpReverse())
+        t.ops.add(OpSHA256())
 
         with self.assertRaises(ValueError):
-            t.ops[OpReverse()] = Timestamp(b'wrong')
+            t.ops[OpSHA256()] = Timestamp(b'wrong')
 
     def test_merge(self):
         """Merging timestamps"""