[dotnetcore] Fix loading of glfw3.dll on windows, Unit-Testing of glfw3 functional… #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity was not possible
|
Hrm, while this does fix it on Core I'm afraid this won't work correctly on .NET Framework. |
deccer
changed the title
|
@frederikja163 As discussed after the last conf call, its only affecting .netcore, not mono, not netframework. but you guys have the last word |
varon
approved these changes
Feb 23, 2020
|
Thanks for this PR @deccer. You've been an enormous help since you've been around. We hope work with you a ton more in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
After a fresh clone of opentk, it was impossible to just run
./build.cmd. It would compile and build, but unit-tests would fail, because nativeloader was not able to locate the proper glfw dll.Unit-Tests were unable to locate glfw3.dll.
Platform (glfw3.dll loading in particular)
N/A
Testing status
build.cmd=> build successful
=> unit-tests threw error glfw3.dll not found
build.cmd=> build successful
=> unit-tests successful