Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUnit Tests from Manuli and Wcdeich4 #373

Merged
merged 3 commits into from Apr 21, 2016
Merged

NUnit Tests from Manuli and Wcdeich4 #373

merged 3 commits into from Apr 21, 2016

Conversation

wcdeich4
Copy link
Contributor

This pull request adds the NUnitTest project with example Vector3 and Matrix4 unit tests written by Wcdeich4 & Manuli respectively. After this is merged in, the unit testing framework is in place, so each developer can make separate Pull Requests to the main repo in the future.

(I wanted to make a few more Vector3 tests before this Pull Request, but I'm relocating for work, so I may be extremely busy the next few weeks & thought it best to get the unit test framework added now to enable everyone to add unit tests)

@paulcscharf
Copy link
Contributor

There are a bunch of changes to the solution file. I'm not an expert on this, but some of them may not be desirable. Could someone with more experience in this check the file?

@wcdeich4
Copy link
Contributor Author

Basically all that was done was to add NUnit 2.6.4 + NUnitTestAdapter 2.6.4 & the NUnitTests project w/ 2 test classes. Of course I'll welcome @cra0zy or anyone to double check the Package Manager console installed things properly.

Now, NUnitTestAdapter is probably what made the most changes b/c it enables Visual Studio & Xamarin to detect NUnit tests & display them in the Test Explorer like they were normal Microsoft Testing Framework unit tests. One reason I wanted to get this pull request submitted now is b/c after this is done, anyone can add unit tests by just adding another test class to the NUnitTes project. But we have to have the framework added for people to do that.

@harry-cpp
Copy link
Contributor

The solution file is alright, Visual Studio just likes to update it(and reorganize it while it's at it).

@wcdeich4 Can you please name the tests project "OpenTK.Tests"?

@wcdeich4
Copy link
Contributor Author

@cra0zy Ok. Might be few couple days, like I mentioned, I'm in the middle of moving from one city to another right now.

@wcdeich4
Copy link
Contributor Author

OK, I think I've got the name changed correctly. Sorry to take so long. Flying from Gainesville FL to Seattle WA was quick, but it took 2 weeks to get internet in my net apartment + another week of being so busy @ work I barely had time to eat, breathe & sleep...

@harry-cpp
Copy link
Contributor

Merging, thanks @wcdeich4 !!!

@harry-cpp harry-cpp merged commit 8e39861 into opentk:develop Apr 21, 2016
@wcdeich4
Copy link
Contributor Author

wcdeich4 commented May 4, 2016

I was looking at the source online & noticed the NUnitTests folder still exists (https://github.com/opentk/opentk/tree/develop/Source/NUnitTests) along side the OpenTK.Tests folder. I think there may have been a minor GIT error pushing from the local copy on my hard drive to my github repo before merging. Anyhow, we can just delete the NUnitTests folder (and of course make sure the .sln knows it's gone)

@wcdeich4
Copy link
Contributor Author

wcdeich4 commented May 11, 2016

I figured it out - the NUnitTests project was completely removed inside Visual Studio, but the files were left just sitting there in GIT, so here is a new PR to fix it. https://github.com/wcdeich4/opentk/pull/1

@harry-cpp
Copy link
Contributor

I fixed it directly in the repo, don't worry.

@wcdeich4
Copy link
Contributor Author

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants