[4.0] Implement 'unmanaged' constraint #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
changed the title
Implement its features using built-in alternatives
FreezyLemon
force-pushed
the
4.0-implement-unmanaged-constraint
branch
from
e783c69
to
7de9ecb
Compare
|
Has mono caught up yet? This would be good to merge. |
|
Mono's preview branch has - we'll need to adjust Travis to compensate (unless that was covered by another PR, can't recall). |
|
It's been done and builds on CI. So it's working then. I'm happy to merge as it's for 4.0, so shouldn't break anything anyway. |
|
In other words, feel free to go ahead and merge @Nihlus , as you've been more in touch with 4.0 than I have. |
|
Travis needs to have its Mono version set to preview before we can safely merge, looks like it wasn't done in another PR. |
|
This commit seems to have the change as part of the PR? bfb4d25 |
|
Oh, silly me. 🤦♂️ Yeah, all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR removes the runtime checks (
BlittableValueType<T>.Checkand the like) for types that can be used in interop and replaces them with the new and shinyunmanagedconstraint for generic types. (more info)Comments
This is blocked until the Mono compiler has support for this language feature (C# language version 7.3).