Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed type for VertexAttribPointer #779

Closed
wants to merge 1 commit into from
Closed

Fixed type for VertexAttribPointer #779

wants to merge 1 commit into from

Conversation

VPeruS
Copy link
Contributor

@VPeruS VPeruS commented Jul 8, 2018 •
edited
Loading

Helper has two functions with same description. This fix it by changing uint to int, this is how it looked in 3.0

@Nihlus
Copy link
Contributor

Nihlus commented Jul 8, 2018

Please provide descriptions in your pull requests. I'm going to close any PR in the future that doesn't have a description.

@Nihlus Nihlus closed this Jul 8, 2018
@varon
Copy link
Member

varon commented Jul 9, 2018

I think he's saying the API Surface used to be int for that function, but I'm not quite sure.

@VPeruS - It's great to see PRs, but a little description goes a long way. I'm sure @Nihlus would gladly re-open this if it uses the PR template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VPeruS @Nihlus @varon