[4.0] Fix numerous binder errors #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
reviewed
Jul 21, 2018
|
|
||
| sw.WriteLine("// ReSharper disable InconsistentNaming"); | ||
| sw.WriteLine("#pragma warning disable SA1139 // Use literal suffix notation instead of casting"); |
There was a problem hiding this comment.
Is this required? I tried looking for places which break this rule but couldn't find any.
There was a problem hiding this comment.
It's mainly for the enumerations and their members - it shows up as a bunch of warnings otherwise.
There was a problem hiding this comment.
Right, that's fine then - I did know what it was for, but couldn't find any examples where it would show warnings. Figured it couldn't hurt to ask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues raised in the binder code, allowing it to build and run again. On top of that, it also improves the API generation step, ensuring that generated code doesn't raise any StyleCop errors or warnings.
This greatly reduces the number of errors in the solution, and lays the groundwork for future improvements to the binder.
There are still some documentation-related issues remaining.