Add common.props for use in all projects #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leezer3
reviewed
Jul 17, 2018
build/targets/common.props
Outdated
| @@ -0,0 +1,5 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <Copyright>Copyright (c) 2006 - 2016 Stefanos Apostolopoulos (stapostol@gmail.com) for the Open Toolkit library.</Copyright> | |||
Nihlus
reviewed
Jul 21, 2018
| @@ -1,7 +1,6 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <Authors>The OpenTK team.</Authors> | |||
There was a problem hiding this comment.
It's probably worth moving this property, too.
There was a problem hiding this comment.
I originally left it in there since VS's description of this element said it was for NuGet:
Could be moved anyways, though.
There was a problem hiding this comment.
Alright, let's keep it there then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
common.propsthat contains properties that should be in every project (currently only copyright)Comments